removed nowait from confirm.select

The ApiGen generates incorrect code for methods that return void and
use nowait.

The generated code has this in it:
>      if (nowait) {
>        ModelSend(__req,null,null);
>      }

It should have this:
>      if (nowait) {
>        ModelSend(__req,null,null);
>        return;
>      }

The functions that do return something, have the return statement in
them.  For instance, see QueuePurge.

Author: Alexandru Scvortov

projects/client/RabbitMQ.Client/src/client/api/IModel.cs

@@ -277,14 +277,9 @@ uint QueueDelete(string queue,
                          bool nowait);
 
         ///<summary>Enable publisher acknowledgements.</summary>
-        [AmqpMethodDoNotImplement(null)]
-            [AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
-        void ConfirmSelect(bool multiple);
-
-        ///<summary>(Spec method) Enable publisher acknowledgements.</summary>
         [AmqpMethodDoNotImplement(null)]
         [AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
-        void ConfirmSelect(bool multiple, bool nowait);
+        void ConfirmSelect(bool multiple);
 
         ///<summary>Start a Basic content-class consumer.</summary>
         ///<remarks>
@@ -568,9 +563,10 @@ void _Private_BasicConsume(string queue,
         ///<summary>Used to send a Confirm.Select method. The public
         ///confirm API calls this while also managing internal
         ///datastructures.</summary>
-        [AmqpMethodMapping(null, "confirm", "select")]
         [AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
+        [AmqpMethodMapping(null, "confirm", "select")]
         void _Private_ConfirmSelect(bool multiple,
+                                    [AmqpNowaitArgument(null)]
                                     bool nowait);
 
 

projects/client/RabbitMQ.Client/src/client/impl/ModelBase.cs

@@ -627,12 +627,8 @@ public abstract uint QueueDelete(string queue,
                                          bool nowait);
 
         public void ConfirmSelect(bool multiple) {
-            ConfirmSelect(multiple, false);
-        }
-
-        public void ConfirmSelect(bool multiple, bool nowait) {
             m_pubMsgCount = 0;
-            _Private_ConfirmSelect(multiple, nowait);
+            _Private_ConfirmSelect(multiple, false);
         }
 
         public abstract void _Private_ConfirmSelect(bool multiple,