Simplify writer code, and throw an exception if the unthinkable happens

lukebakken · lukebakken · commit bcde29e058f2 · 2023-03-01T09:10:31.000-08:00
diff --git a/projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs b/projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs
@@ -250,16 +250,15 @@ public bool TryReadFrame(out InboundFrame frame)
 
         public void SendHeader()
         {
-#if NET
-            _pipeWriter.AsStream().Write(ProtocolHeader);
-#else
-            _pipeWriter.AsStream().Write(ProtocolHeader.ToArray(), 0, ProtocolHeader.Length);
-#endif
+            _pipeWriter.Write(ProtocolHeader);
         }
 
         public void Write(ReadOnlyMemory<byte> memory)
         {
-            _channelWriter.TryWrite(memory);
+            if (!_channelWriter.TryWrite(memory))
+            {
+                throw new ApplicationException("Please report this bug here: https://github.com/rabbitmq/rabbitmq-dotnet-client/issues");
+            }
         }
 
         private async Task WriteLoop()

Original file line number	Diff line number	Diff line change
`@@ -250,16 +250,15 @@ public bool TryReadFrame(out InboundFrame frame)`
`250`	`250`
`251`	`251`	`public void SendHeader()`
`252`	`252`	`{`
`253`		`-#if NET`
`254`		`- _pipeWriter.AsStream().Write(ProtocolHeader);`
`255`		`-#else`
`256`		`- _pipeWriter.AsStream().Write(ProtocolHeader.ToArray(), 0, ProtocolHeader.Length);`
`257`		`-#endif`
	`253`	`+ _pipeWriter.Write(ProtocolHeader);`
`258`	`254`	`}`
`259`	`255`
`260`	`256`	`public void Write(ReadOnlyMemory<byte> memory)`
`261`	`257`	`{`
`262`		`- _channelWriter.TryWrite(memory);`
	`258`	`+ if (!_channelWriter.TryWrite(memory))`
	`259`	`+ {`
	`260`	`+ throw new ApplicationException("Please report this bug here: https://github.com/rabbitmq/rabbitmq-dotnet-client/issues");`
	`261`	`+ }`
`263`	`262`	`}`
`264`	`263`
`265`	`264`	`private async Task WriteLoop()`