Ignore NotSupportedException thrown by BufferedStream writes

michaelklishin · michaelklishin · commit bd2e60d5ede4 · 2014-03-24T12:02:32.000+04:00
The issue seems to be an unfortunate buffered stream behaviour
aspect when there's data to read and a write is attempted.

Since this exception is very confusing and our intent is to shut
down anyway, we ignore it.
diff --git a/projects/client/RabbitMQ.Client/src/client/impl/ConnectionBase.cs b/projects/client/RabbitMQ.Client/src/client/impl/ConnectionBase.cs
@@ -485,6 +485,11 @@ public void Close(ShutdownEventArgs reason, bool abort, int timeout)
                     if (!abort)
                         throw ace;
                 }
+                catch (NotSupportedException nse)
+                {
+                    // buffered stream had unread data in it and Flush()
+                    // was called, ignore to not confuse the user
+                }
                 catch (IOException ioe)
                 {
                     if (m_model0.CloseReason == null)

Original file line number	Diff line number	Diff line change
`@@ -485,6 +485,11 @@ public void Close(ShutdownEventArgs reason, bool abort, int timeout)`
`485`	`485`	`if (!abort)`
`486`	`486`	`throw ace;`
`487`	`487`	`}`
	`488`	`+ catch (NotSupportedException nse)`
	`489`	`+ {`
	`490`	`+ // buffered stream had unread data in it and Flush()`
	`491`	`+ // was called, ignore to not confuse the user`
	`492`	`+ }`
`488`	`493`	`catch (IOException ioe)`
`489`	`494`	`{`
`490`	`495`	`if (m_model0.CloseReason == null)`