Merge pull request #406 from paulomorgado/obsolete-AutoClose

michaelklishin · web-flow · commit d0096f62bc8b · 2018-04-10T18:00:26.000+08:00
Add ObsoleteAttribuite to IConnection.AutoClose
diff --git a/projects/client/RabbitMQ.Client/src/client/api/IConnection.cs b/projects/client/RabbitMQ.Client/src/client/api/IConnection.cs
@@ -74,6 +74,7 @@ public interface IConnection : NetworkConnection, IDisposable
         /// DON'T set AutoClose to true before opening the first
         /// channel, because the connection will be immediately closed if you do!
         /// </remarks>
+        [Obsolete("Please explicitly close connections instead.")]
         bool AutoClose { get; set; }
 
         /// <summary>
diff --git a/projects/client/RabbitMQ.Client/src/client/impl/AutorecoveringConnection.cs b/projects/client/RabbitMQ.Client/src/client/impl/AutorecoveringConnection.cs
@@ -294,6 +294,7 @@ public event EventHandler<EventArgs> Recovery
 
         public string ClientProvidedName { get; private set; }
 
+        [Obsolete("Please explicitly close connections instead.")]
         public bool AutoClose
         {
             get { return m_delegate.AutoClose; }
diff --git a/projects/client/RabbitMQ.Client/src/client/impl/Connection.cs b/projects/client/RabbitMQ.Client/src/client/impl/Connection.cs
@@ -273,6 +273,7 @@ public event EventHandler<ConnectionRecoveryErrorEventArgs> ConnectionRecoveryEr
         }
         public string ClientProvidedName { get; private set; }
 
+        [Obsolete("Please explicitly close connections instead.")]
         public bool AutoClose
         {
             get { return m_sessionManager.AutoClose; }
diff --git a/projects/client/RabbitMQ.Client/src/client/impl/SessionManager.cs b/projects/client/RabbitMQ.Client/src/client/impl/SessionManager.cs
@@ -68,6 +68,7 @@ public SessionManager(Connection connection, ushort channelMax)
             Ints = new IntAllocator(1, ChannelMax);
         }
 
+        [Obsolete("Please explicitly close connections instead.")]
         public bool AutoClose
         {
             get { return m_autoClose; }

Original file line number	Diff line number	Diff line change
`@@ -294,6 +294,7 @@ public event EventHandler<EventArgs> Recovery`
`294`	`294`
`295`	`295`	`public string ClientProvidedName { get; private set; }`
`296`	`296`
	`297`	`+ [Obsolete("Please explicitly close connections instead.")]`
`297`	`298`	`public bool AutoClose`
`298`	`299`	`{`
`299`	`300`	`get { return m_delegate.AutoClose; }`
Original file line number	Diff line number	Diff line change
`@@ -273,6 +273,7 @@ public event EventHandler<ConnectionRecoveryErrorEventArgs> ConnectionRecoveryEr`
`273`	`273`	`}`
`274`	`274`	`public string ClientProvidedName { get; private set; }`
`275`	`275`
	`276`	`+ [Obsolete("Please explicitly close connections instead.")]`
`276`	`277`	`public bool AutoClose`
`277`	`278`	`{`
`278`	`279`	`get { return m_sessionManager.AutoClose; }`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ public SessionManager(Connection connection, ushort channelMax)`
`68`	`68`	`Ints = new IntAllocator(1, ChannelMax);`
`69`	`69`	`}`
`70`	`70`
	`71`	`+ [Obsolete("Please explicitly close connections instead.")]`
`71`	`72`	`public bool AutoClose`
`72`	`73`	`{`
`73`	`74`	`get { return m_autoClose; }`