Throw meaningful exception if server fails start connection

Author: Emile Joubert

RabbitMQDotNetClient.sln

@@ -1,5 +1,5 @@
 
-Microsoft Visual Studio Solution File, Format Version 9.00
+Microsoft Visual Studio Solution File, Format Version 10.00
 # Visual Studio 2008
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "projects", "projects", "{068D7DC3-8E6E-4951-B9E3-272C641BF0DE}"
 EndProject

projects/client/RabbitMQ.Client/src/client/exceptions/ProtocolVersionMismatchException.cs

@@ -75,14 +75,18 @@ public class ProtocolVersionMismatchException: System.Net.ProtocolViolationExcep
         ///<summary>The peer's AMQP specification minor version.</summary>
         public int ServerMinor { get { return m_serverMinor; } }
 
+        private static String positiveOrUnknown(int version){
+            return version >= 0 ? version.ToString() : "unknown";
+        }
+
         ///<summary>Fills the new instance's properties with the values passed in.</summary>
         public ProtocolVersionMismatchException(int clientMajor,
                                                 int clientMinor,
                                                 int serverMajor,
                                                 int serverMinor)
             : base("AMQP server protocol negotiation failure: server version "+
-                   serverMajor + "-" + serverMinor +
-                   ", client version " + clientMajor + "-" + clientMinor)
+                   positiveOrUnknown(serverMajor) + "-" + positiveOrUnknown(serverMinor) +
+                   ", client version " + positiveOrUnknown(clientMajor) + "-" + positiveOrUnknown(clientMinor))
         {
             m_clientMajor = clientMajor;
             m_clientMinor = clientMinor;

projects/client/RabbitMQ.Client/src/client/impl/ConnectionBase.cs

@@ -977,6 +977,12 @@ public void Open(bool insist)
 
             ConnectionStartDetails connectionStart = (ConnectionStartDetails)
                 connectionStartCell.Value;
+            
+            if (connectionStart == null){
+                throw new ProtocolVersionMismatchException(Protocol.MajorVersion,
+                                                           Protocol.MinorVersion,
+                                                           -1, -1);
+            }
 
             ServerProperties = connectionStart.m_serverProperties;
 

projects/examples/client/SendString/src/examples/SendString.cs

@@ -65,6 +65,7 @@ public static int Main(string[] args) {
             if (args.Length < 5) {
                 Console.Error.WriteLine("Usage: SendString <hostname>[:<portnumber>] <exchange> <exchangetype> <routingkey> <message>");
                 Console.Error.WriteLine("RabbitMQ .NET client version "+typeof(IModel).Assembly.GetName().Version.ToString());
+                Console.ReadKey();
                 return 2;
             }
 
@@ -75,6 +76,7 @@ public static int Main(string[] args) {
             string message = args[4];
 
             ConnectionFactory cf = new ConnectionFactory();
+            //cf.Protocol = Protocols.AMQP_0_9_1;
             cf.Address = serverAddress;     
 
             using (IConnection conn = cf.CreateConnection())
@@ -88,6 +90,8 @@ public static int Main(string[] args) {
                                         routingKey,
                                         null,
                                         Encoding.UTF8.GetBytes(message));
+                        Console.WriteLine("published ok");
+                        Console.ReadKey();
                         return 0;
                     }
                 }