Exception when disabling heartbeat with v7

[Socolin]

Describe the bug

Looks like ConnectionFactory.RequestedHeartbeat no longer accept Timespan.Zero as documented

        /// <summary>
        /// Default value for desired heartbeat interval. Default is 60 seconds,
        /// TimeSpan.Zero means "heartbeats are disabled".
        /// </summary>

RabbitMQ.Client.Exceptions.BrokerUnreachableException : None of the specified endpoints were reachable
  ----> System.AggregateException : One or more errors occurred. (Timeout can be only be set to 'System.Threading.Timeout.Infinite' or a value > 0. (Parameter 'value'))
  ----> System.ArgumentOutOfRangeException : Timeout can be only be set to 'System.Threading.Timeout.Infinite' or a value > 0. (Parameter 'value')
   at RabbitMQ.Client.ConnectionFactory.CreateConnectionAsync(IEndpointResolver endpointResolver, String clientProvidedName, CancellationToken cancellationToken)

Crash in ConfigureFrameHandler this line

 fh.ReadTimeout = RequestedHeartbeat;

Reproduction steps

var connectionFactory = new ConnectionFactory
{
	Uri = uri,
	AutomaticRecoveryEnabled = true,
	RequestedHeartbeat = TimeSpan.Zero,
};

_connection = await connectionFactory.CreateConnectionAsync("some-name");

Expected behavior

Should not crash, or crash with a clear error message if this is not valid anymore.

Additional context

No response

[lukebakken]

Thanks for taking the time to report the incorrect XML docs. I'll update the XML docs, but this is pretty clear:

System.ArgumentOutOfRangeException : Timeout can be only be set to 'System.Threading.Timeout.Infinite' or a value > 0. (Parameter 'value')

Also, disabling the heartbeat is a bad practice.

[Socolin]

Well, the exception message is not very clear, since we don't know what timeout is wrong, would be nice to get a message saying this is related to the heartbeat.

It was old test for a library, I know this is bad practice, I just spent 30 minutes trying to understand what was causing this issue.

[lukebakken]

would be nice to get a message saying this is related to the heartbeat

Ah, yes, I agree. Thanks for pointing that out.

[lukebakken]

#1774