Don't abuse setHeartbeat(0) for actually stopping the heartbeater

Matthew Sackman · Matthew Sackman · commit 1d13f2fa974a · 2010-10-15T13:46:50.000+01:00
diff --git a/src/com/rabbitmq/client/impl/AMQConnection.java b/src/com/rabbitmq/client/impl/AMQConnection.java
@@ -541,7 +541,7 @@ public void handleConnectionClose(Command closeCommand) {
         } catch (IOException ioe) {
             Utility.emptyStatement();
         }
-        setHeartbeat(0); // Do not try to send heartbeats after CloseOk
+        _heartbeatSender.shutdown(); // Do not try to send heartbeats after CloseOk
         _brokerInitiatedShutdown = true;
         Thread scw = new SocketCloseWait(sse);
         scw.setName("AMQP Connection Closing Monitor " +

Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,7 @@ public void handleConnectionClose(Command closeCommand) {`
`541`	`541`	`} catch (IOException ioe) {`
`542`	`542`	`Utility.emptyStatement();`
`543`	`543`	`}`
`544`		`- setHeartbeat(0); // Do not try to send heartbeats after CloseOk`
	`544`	`+ _heartbeatSender.shutdown(); // Do not try to send heartbeats after CloseOk`
`545`	`545`	`_brokerInitiatedShutdown = true;`
`546`	`546`	`Thread scw = new SocketCloseWait(sse);`
`547`	`547`	`scw.setName("AMQP Connection Closing Monitor " +`