Comparing to Integer.MAX_VALUE - 1 does not get binned by HotSpot

0x6e6562 · 0x6e6562 · commit 63c6ec416134 · 2009-08-05T12:47:57.000+01:00
diff --git a/src/com/rabbitmq/client/impl/ChannelManager.java b/src/com/rabbitmq/client/impl/ChannelManager.java
@@ -98,7 +98,7 @@ public synchronized ChannelN createChannel(AMQConnection connection, int channel
 
     public synchronized int allocateChannelNumber(int maxChannels) {
         if (maxChannels == 0) {
-            maxChannels = Integer.MAX_VALUE;
+            maxChannels = Integer.MAX_VALUE - 1;
         }
         int channelNumber = -1;
         for (int candidate = 1; candidate <= maxChannels; candidate++) {

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ public synchronized ChannelN createChannel(AMQConnection connection, int channel`
`98`	`98`
`99`	`99`	`public synchronized int allocateChannelNumber(int maxChannels) {`
`100`	`100`	`if (maxChannels == 0) {`
`101`		`- maxChannels = Integer.MAX_VALUE;`
	`101`	`+ maxChannels = Integer.MAX_VALUE - 1;`
`102`	`102`	`}`
`103`	`103`	`int channelNumber = -1;`
`104`	`104`	`for (int candidate = 1; candidate <= maxChannels; candidate++) {`