use BrokerTestCase.expectError to catch expected errors

which handles the case of the connection already being closed by the
time we invoke the next command after an error-inducing basicPublish.

In the process I changed the code to use more of the existing
BrokerTestCase infrastructure and reduce the dependence on the
knowledge of client library internals.

Author: rade

test/src/com/rabbitmq/client/test/functional/UnexpectedFrames.java

@@ -13,13 +13,50 @@
  * Test that the server correctly handles us when we send it bad frames
  */
 public class UnexpectedFrames extends BrokerTestCase {
+
     private interface Confuser {
         public Frame confuse(Frame frame) throws IOException;
     }
 
-    @Override protected void setUp() throws IOException {}
+    private static class ConfusedFrameHandler extends SocketFrameHandler {
+        public ConfusedFrameHandler(Socket socket) throws IOException {
+            super(socket);
+        }
+
+        @Override
+        public void writeFrame(Frame frame) throws IOException {
+            Frame confusedFrame = new Frame();
+            confusedFrame.accumulator = frame.accumulator;
+            confusedFrame.channel = frame.channel;
+            confusedFrame.type = frame.type;
+
+            confusedFrame = confuser.confuse(confusedFrame);
+            if (confusedFrame != null) {
+                super.writeFrame(confusedFrame);
+            }
+        }
+
+        public Confuser confuser = new Confuser() {
+            public Frame confuse(Frame frame) {
+                // Do nothing to start with, we need to negotiate before the
+                // server will send us unexpected_frame errors
+                return frame;
+            }
+        };
+    }
+
+    private static class ConfusedConnectionFactory extends ConnectionFactory {
+
+        @Override protected FrameHandler createFrameHandler(Socket sock)
+            throws IOException {
+            return new ConfusedFrameHandler(sock);
+        }
+    }
 
-    @Override protected void tearDown() throws IOException {}
+    public UnexpectedFrames() {
+        super();
+        connectionFactory = new ConfusedConnectionFactory();
+    }
 
     public void testMissingHeader() throws IOException {
         expectUnexpectedFrameError(new Confuser() {
@@ -73,53 +110,16 @@ public Frame confuse(Frame frame) throws IOException {
         });
     }
 
-    private void expectUnexpectedFrameError(Confuser confuser) throws IOException {
-        ConnectionFactory factory = new ConnectionFactory();
-        Socket socket = factory.getSocketFactory().createSocket("localhost",
-                AMQP.PROTOCOL.PORT);
-        ConfusedFrameHandler handler = new ConfusedFrameHandler(socket);
-        AMQConnection connection = new AMQConnection(factory, handler);
-        connection.start();
-        Channel channel = connection.createChannel();
-
-        handler.confuser = confuser;
-
-        try {
-            //NB: the frame confuser relies on the encoding of the
-            //method field to be at least 8 bytes long
-            channel.basicPublish("", "routing key", null, "Hello".getBytes());
-            channel.basicQos(0);
-            fail("We should have seen an UNEXPECTED_FRAME by now");
-        }
-        catch (IOException e) {
-            checkShutdownSignal(AMQP.UNEXPECTED_FRAME, e);
-        }
-    }
-
-    private static class ConfusedFrameHandler extends SocketFrameHandler {
-        public ConfusedFrameHandler(Socket socket) throws IOException {
-            super(socket);
-        }
-
-        @Override
-        public void writeFrame(Frame frame) throws IOException {
-            Frame confusedFrame = new Frame();
-            confusedFrame.accumulator = frame.accumulator;
-            confusedFrame.channel = frame.channel;
-            confusedFrame.type = frame.type;
+    private void expectUnexpectedFrameError(Confuser confuser)
+        throws IOException {
 
-            confusedFrame = confuser.confuse(confusedFrame);
-            if (confusedFrame != null) {
-                super.writeFrame(confusedFrame);
-            }
-        }
+        ((ConfusedFrameHandler)((AMQConnection)connection).getFrameHandler()).
+            confuser = confuser;
 
-        public Confuser confuser = new Confuser() {
-            public Frame confuse(Frame frame) {
-                // Do nothing to start with, we need to negotiate before the
-                // server will send us unexpected_frame errors
-                return frame;
-            }
-        };
+        //NB: the frame confuser relies on the encoding of the
+        //method field to be at least 8 bytes long
+        channel.basicPublish("", "routing key", null, "Hello".getBytes());
+        expectError(AMQP.UNEXPECTED_FRAME);
     }
+
 }