Test (Possible)AuthenticationFailureException

Author: Emile Joubert

test/src/com/rabbitmq/client/test/functional/SaslMechanisms.java

@@ -16,17 +16,25 @@
 
 package com.rabbitmq.client.test.functional;
 
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.AuthenticationFailureException;
 import com.rabbitmq.client.Connection;
 import com.rabbitmq.client.ConnectionFactory;
 import com.rabbitmq.client.LongString;
 import com.rabbitmq.client.PossibleAuthenticationFailureException;
 import com.rabbitmq.client.SaslConfig;
 import com.rabbitmq.client.SaslMechanism;
+import com.rabbitmq.client.impl.AMQConnection;
 import com.rabbitmq.client.impl.LongStringHelper;
+import com.rabbitmq.client.impl.SocketFrameHandler;
 import com.rabbitmq.client.test.BrokerTestCase;
 
+import javax.net.SocketFactory;
 import java.io.IOException;
 import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.Executors;
 
 public class SaslMechanisms extends BrokerTestCase {
     private String[] mechanisms;
@@ -91,6 +99,47 @@ public void testCRLogin() throws IOException {
         }
     }
 
+    public void testConnectionCloseAuthFailureUsername() throws IOException {
+        connectionCloseAuthFailure("incorrect-username", "incorrect-password");
+    }
+
+    public void testConnectionCloseAuthFailurePassword() throws IOException {
+        connectionCloseAuthFailure(connectionFactory.getUsername(), "incorrect-password");
+    }
+
+    public void connectionCloseAuthFailure(String username, String password) throws IOException {
+        String failDetail =  "for username " + username + " and password " + password;
+        try {
+            Connection conn = connectionWithoutCapabilities(username, password);
+            fail("Expected PossibleAuthenticationFailureException " + failDetail);
+            conn.abort();
+        } catch (PossibleAuthenticationFailureException paf) {
+            if (paf instanceof AuthenticationFailureException) {
+                fail("Not expecting AuthenticationFailureException " + failDetail);
+            }
+        }
+    }
+
+    // start a connection without capabilities, causing authentication failures
+    // to be reported by the broker by closing the connection
+    private Connection connectionWithoutCapabilities(String username, String password) throws IOException {
+        Map<String, Object> customProperties = connection.getClientProperties();
+        customProperties.remove("capabilities");
+        AMQConnection conn =
+                new AMQConnection(username,
+                                  password,
+                                  new SocketFrameHandler(SocketFactory.getDefault().createSocket("localhost", AMQP.PROTOCOL.PORT)),
+                                  Executors.newFixedThreadPool(1),
+                                  connectionFactory.getVirtualHost(),
+                                  customProperties,
+                                  connectionFactory.getRequestedFrameMax(),
+                                  connectionFactory.getRequestedChannelMax(),
+                                  connectionFactory.getRequestedHeartbeat(),
+                                  connectionFactory.getSaslConfig());
+        conn.start();
+        return conn;
+    }
+
     private void loginOk(String name, byte[][] responses) throws IOException {
         ConnectionFactory factory = new ConnectionFactory();
         factory.setSaslConfig(new Config(name, responses));
@@ -102,7 +151,7 @@ private void loginBad(String name, byte[][] responses) throws IOException {
         try {
             loginOk(name, responses);
             fail("Login succeeded!");
-        } catch (PossibleAuthenticationFailureException e) {
+        } catch (AuthenticationFailureException e) {
             // Ok
         }
     }

test/src/com/rabbitmq/client/test/server/Permissions.java

@@ -18,7 +18,7 @@
 package com.rabbitmq.client.test.server;
 
 import com.rabbitmq.client.AlreadyClosedException;
-import com.rabbitmq.client.PossibleAuthenticationFailureException;
+import com.rabbitmq.client.AuthenticationFailureException;
 import com.rabbitmq.client.test.BrokerTestCase;
 import java.io.IOException;
 import java.util.Map;
@@ -127,7 +127,7 @@ public void testAuth()
             unAuthFactory.newConnection();
             fail("Exception expected if password is wrong");
         } catch (IOException e) {
-            assertTrue(e instanceof PossibleAuthenticationFailureException);
+            assertTrue(e instanceof AuthenticationFailureException);
             String msg = e.getMessage();
             assertTrue("Exception message should contain 'auth'",
                        msg.toLowerCase().contains("auth"));