Refactor to avoid passing BrokerTestCases around...

Author: Simon MacMullen

test/src/com/rabbitmq/client/test/functional/ExchangeDeclare.java

@@ -35,12 +35,7 @@
 import java.util.HashMap;
 import java.io.IOException;
 
-import com.rabbitmq.client.AMQP;
-import com.rabbitmq.client.Channel;
-
-import com.rabbitmq.client.test.BrokerTestCase;
-
-public class ExchangeDeclare extends BrokerTestCase {
+public class ExchangeDeclare extends ExchangeEquivalenceBase {
 
     static final String TYPE = "direct";
 
@@ -50,51 +45,30 @@ public void releaseResources() throws IOException {
         channel.exchangeDelete(NAME);
     }
 
-    public static void verifyEquivalent(BrokerTestCase btc, String name,
-            String type, boolean durable, boolean autoDelete,
-            Map<String, Object> args) throws IOException {
-        btc.channel.exchangeDeclarePassive(name);
-        btc.channel.exchangeDeclare(name, type, durable, autoDelete, args);
-    }
-
-    // Note: this will close the channel
-    public static void verifyNotEquivalent(BrokerTestCase btc, String name,
-            String type, boolean durable, boolean autoDelete,
-            Map<String, Object> args) throws IOException {
-        btc.channel.exchangeDeclarePassive(name);
-        try {
-            btc.channel.exchangeDeclare(name, type, durable, autoDelete, args);
-            fail("Exchange was supposed to be not equivalent");
-        } catch (IOException ioe) {
-            btc.checkShutdownSignal(AMQP.NOT_ALLOWED, ioe);
-            return;
-        }
-    }
-
     public void testExchangeNoArgsEquivalence() throws IOException {
         channel.exchangeDeclare(NAME, TYPE, false, false, null);
-        verifyEquivalent(this, NAME, TYPE, false, false, null);
+        verifyEquivalent(NAME, TYPE, false, false, null);
     }
 
     public void testExchangeNonsenseArgsEquivalent() throws IOException {
         channel.exchangeDeclare(NAME, TYPE, false, false, null);
         Map<String, Object> args = new HashMap<String, Object>();
         args.put("nonsensical-argument-surely-not-in-use", "foo");
-        verifyEquivalent(this, NAME, TYPE, false, false, args);
+        verifyEquivalent(NAME, TYPE, false, false, args);
     }
 
     public void testExchangeDurableNotEquivalent() throws IOException {
         channel.exchangeDeclare(NAME, TYPE, false, false, null);
-        verifyNotEquivalent(this, NAME, TYPE, true, false, null);
+        verifyNotEquivalent(NAME, TYPE, true, false, null);
     }
 
     public void testExchangeTypeNotEquivalent() throws IOException {
         channel.exchangeDeclare(NAME, "direct", false, false, null);
-        verifyNotEquivalent(this, NAME, "fanout", false, false, null);
+        verifyNotEquivalent(NAME, "fanout", false, false, null);
     }
 
     public void testExchangeAutoDeleteNotEquivalent() throws IOException {
         channel.exchangeDeclare(NAME, "direct", false, false, null);
-        verifyNotEquivalent(this, NAME, "direct", false, true, null);
+        verifyNotEquivalent(NAME, "direct", false, true, null);
     }
 }

test/src/com/rabbitmq/client/test/functional/ExchangeEquivalenceBase.java

@@ -0,0 +1,30 @@
+package com.rabbitmq.client.test.functional;
+
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.test.BrokerTestCase;
+
+import java.io.IOException;
+import java.util.Map;
+
+public abstract class ExchangeEquivalenceBase extends BrokerTestCase {
+    public void verifyEquivalent(String name,
+            String type, boolean durable, boolean autoDelete,
+            Map<String, Object> args) throws IOException {
+        channel.exchangeDeclarePassive(name);
+        channel.exchangeDeclare(name, type, durable, autoDelete, args);
+    }
+
+    // Note: this will close the channel
+    public void verifyNotEquivalent(String name,
+            String type, boolean durable, boolean autoDelete,
+            Map<String, Object> args) throws IOException {
+        channel.exchangeDeclarePassive(name);
+        try {
+            channel.exchangeDeclare(name, type, durable, autoDelete, args);
+            fail("Exchange was supposed to be not equivalent");
+        } catch (IOException ioe) {
+            checkShutdownSignal(AMQP.NOT_ALLOWED, ioe);
+            return;
+        }
+    }
+}

test/src/com/rabbitmq/client/test/server/ExchangeEquivalence.java renamed to test/src/com/rabbitmq/client/test/server/AlternateExchangeEquivalence.java

@@ -35,26 +35,23 @@
 import java.util.HashMap;
 import java.io.IOException;
 
-import com.rabbitmq.client.test.BrokerTestCase;
-import com.rabbitmq.client.test.functional.ExchangeDeclare;
+import com.rabbitmq.client.test.functional.ExchangeEquivalenceBase;
 
-public class ExchangeEquivalence extends BrokerTestCase {
+public class AlternateExchangeEquivalence extends ExchangeEquivalenceBase {
     static Map<String, Object> args = new HashMap<String, Object>();
     {
         args.put("alternate-exchange", "UME");
     }
 
     public void testAlternateExchangeEquivalence() throws IOException {
         channel.exchangeDeclare("alternate", "direct", false, false, args);
-        ExchangeDeclare.verifyEquivalent(this, "alternate", "direct", false,
-                false, args);
+        verifyEquivalent("alternate", "direct", false, false, args);
     }
 
     public void testAlternateExchangeNonEquivalence() throws IOException {
         channel.exchangeDeclare("alternate", "direct", false, false, args);
         Map<String, Object> altargs = new HashMap<String, Object>();
         altargs.put("alternate-exchange", "somewhere");
-        ExchangeDeclare.verifyNotEquivalent(this, "alternate", "direct",
-                false, false, altargs);
+        verifyNotEquivalent("alternate", "direct", false, false, altargs);
     }
 }

test/src/com/rabbitmq/client/test/server/ServerTests.java

@@ -42,7 +42,7 @@ public static TestSuite suite() {
         suite.addTestSuite(EffectVisibilityCrossNodeTest.class);
         suite.addTest(PersisterRestartTests.suite());
         suite.addTestSuite(ExclusiveQueueDurability.class);
-        suite.addTestSuite(ExchangeEquivalence.class);
+        suite.addTestSuite(AlternateExchangeEquivalence.class);
         return suite;
     }
 }