Skip to content

Commit fbd707c

Browse files
Wording, cosmetics
1 parent 4e223b2 commit fbd707c

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

src/test/java/com/rabbitmq/client/test/NoAutoRecoveryWhenTcpWindowIsFullTest.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,24 @@
4646
import static org.junit.Assert.assertThat;
4747

4848
/**
49-
* Test to trigger and check the fix of https://github.com/rabbitmq/rabbitmq-java-client/issues/341.
50-
* Conditions:
51-
* - client registers consumer
52-
* - client get many messages as the consumer is slow
53-
* - the work pool queue is full, the reading thread is stuck
54-
* - more messages come from the network and saturates the TCP buffer
55-
* - the connection dies but the client doesn't detect it
56-
* - sending in the consumer fails
57-
* - connection recovery is never triggered
49+
* Test to trigger and check the fix of rabbitmq/rabbitmq-java-client#341,
50+
* which can be summarized as
51+
*
52+
* <ul>
53+
* <li>client registers a slow consumer in automatic acknowledgement mode</li>
54+
* <li>there's a fast enough publisher</li>
55+
* <li>the consumer gets flooded with deliveries</li>
56+
* <li>the work pool queue is full, the reading thread is stuck</li>
57+
* <li>more messages come from the network and it fills up the TCP buffer</li>
58+
* <li>the connection is closed by the server due to missed heartbeats but the client doesn't detect it</li>
59+
* <li>a write operation fails because the socket is closed</li>
60+
* <li>connection recovery is never triggered</li>
61+
* </ul>
62+
*
5863
* <p>
5964
* The fix consists in triggering connection recovery when writing
6065
* to the socket fails.
66+
* </p>
6167
*/
6268
public class NoAutoRecoveryWhenTcpWindowIsFullTest {
6369

@@ -80,7 +86,7 @@ public void setUp() throws Exception {
8086
final ConnectionFactory factory = TestUtils.connectionFactory();
8187
factory.setSocketConfigurator(new DefaultSocketConfigurator() {
8288

83-
/* default value on a Linux platform */
89+
/* default value on Linux */
8490
int DEFAULT_RECEIVE_BUFFER_SIZE = 43690;
8591

8692
@Override

0 commit comments

Comments
 (0)