Bundle perf-test artefact in the Docker image

Push all Docker image building concerns into the Dockerfile. This
ensures that it will always work, regardless of the host that builds the
Docker image.

Author: gerhard

Dockerfile

@@ -1,7 +1,15 @@
 FROM openjdk:8u181-jre-alpine3.8
 
-ARG perf_test_distribution
-RUN apk add --no-cache bash
-VOLUME /tmp
-COPY $perf_test_distribution/ /tmp/
-ENTRYPOINT ["/tmp/bin/runjava", "com.rabbitmq.perf.PerfTest"]
+ARG perf_test_version
+ENV URL=https://github.com/rabbitmq/rabbitmq-perf-test/releases/download/v$perf_test_version/rabbitmq-perf-test-$perf_test_version-bin.tar.gz
+
+RUN apk add --no-cache bash curl ca-certificates
+
+# Fail fast if URL is invalid
+RUN curl --verbose --head --fail $URL 1>/dev/null
+
+# Download into /perf_test & ensure that it works correctly
+RUN mkdir -p /perf_test && cd /perf_test && curl --location --silent --fail --output - $URL | tar x -z -v -f - --strip-components 1 && bin/runjava com.rabbitmq.perf.PerfTest --help
+WORKDIR /perf_test
+
+ENTRYPOINT ["bin/runjava", "com.rabbitmq.perf.PerfTest"]

Makefile

@@ -11,6 +11,8 @@ HARDWARE := $$(uname -m | tr '[:upper:]' '[:lower:]')
 
 GPG_KEYNAME := $$(awk -F'[<>]' '/<gpg.keyname>/ { print $$3 }' pom.xml)
 
+RELEASE_VERSION ?= 2.3.0
+
 ### TARGETS ###
 #
 
@@ -23,12 +25,12 @@ native-image: clean ## Build the native image
 	@mvnw -q package -DskipTests -P native-image -P '!java-packaging'
 	native-image -jar target/perf-test.jar -H:Features="com.rabbitmq.perf.NativeImageFeature"
 
-docker-image:
-	rm -rf rabbitmq-perf-test-$(RELEASE_VERSION)*
-	wget https://github.com/rabbitmq/rabbitmq-perf-test/releases/download/v$(RELEASE_VERSION)/rabbitmq-perf-test-$(RELEASE_VERSION)-bin.tar.gz
-	tar -xf rabbitmq-perf-test-$(RELEASE_VERSION)-bin.tar.gz
-	docker build --build-arg perf_test_distribution=rabbitmq-perf-test-$(RELEASE_VERSION) -t pivotalrabbitmq/perf-test:$(RELEASE_VERSION) -t pivotalrabbitmq/perf-test:latest .
-	rm -rf rabbitmq-perf-test-$(RELEASE_VERSION)*
+.PHONY: docker-image
+docker-image: ## Build Docker image
+	@docker build \
+	  --tag pivotalrabbitmq/perf-test:$(RELEASE_VERSION) \
+	  --tag pivotalrabbitmq/perf-test:latest \
+	  --build-arg perf_test_version=$(RELEASE_VERSION) .
 
 .PHONY: package-native-image
 package-native-image: native-image ## Package the native image