Skip to content

Commit 6b59258

Browse files
committed
Prefix --queue-pattern- prefix for --from and --to
And use printf-like format to expand queues names, e.g. --queue-pattern perf-test-%d References #64
1 parent 240d29f commit 6b59258

File tree

5 files changed

+25
-17
lines changed

5 files changed

+25
-17
lines changed

pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,13 +126,15 @@
126126
<groupId>org.junit.jupiter</groupId>
127127
<artifactId>junit-jupiter-migrationsupport</artifactId>
128128
<version>${junit.jupiter.version}</version>
129+
<scope>test</scope>
129130
</dependency>
130131

131132
<!-- for parameterized tests -->
132133
<dependency>
133134
<groupId>org.junit.jupiter</groupId>
134135
<artifactId>junit-jupiter-params</artifactId>
135136
<version>${junit.jupiter.version}</version>
137+
<scope>test</scope>
136138
</dependency>
137139

138140
<dependency>

src/main/java/com/rabbitmq/perf/MulticastParams.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,7 @@ public SequenceTopologyHandler(MulticastParams params, int from, int to, String
556556
super(params);
557557
queues = new ArrayList<>(to - from + 1);
558558
for (int i = from; i <= to; i++) {
559-
queues.add(queuePattern.replaceAll("\\$\\{i\\}", String.valueOf(i)));
559+
queues.add(String.format(queuePattern, i));
560560
}
561561
}
562562

src/main/java/com/rabbitmq/perf/PerfTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,8 @@ private static Options getOptions() {
302302
options.addOption(new Option("v", "version", false,"print version information"));
303303

304304
options.addOption(new Option("qp", "queue-pattern", true, "queue name pattern for creating queues in sequence"));
305-
options.addOption(new Option("F", "from", true, "sequence start (included)"));
306-
options.addOption(new Option("T", "to", true, "sequence end (included)"));
305+
options.addOption(new Option("F", "queue-pattern-from", true, "sequence start for queue pattern (included)"));
306+
options.addOption(new Option("T", "queue-pattern-to", true, "sequence end for queue pattern (included)"));
307307
return options;
308308
}
309309

src/test/java/com/rabbitmq/perf/SequenceTopologyHandlerTest.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class SequenceTopologyHandlerTest {
3131

3232
@Test
3333
public void sequence() {
34-
handler = new MulticastParams.SequenceTopologyHandler(null, 1, 5, "test-${i}");
34+
handler = new MulticastParams.SequenceTopologyHandler(null, 1, 5, "test-%d");
3535
assertThat(handler.getQueueNames(), allOf(iterableWithSize(5), hasItems("test-1", "test-2", "test-3", "test-4", "test-5")));
3636

3737
assertThat(handler.getRoutingKey(), is("test-1"));
@@ -56,7 +56,7 @@ public void sequence() {
5656

5757
@Test
5858
public void reset() {
59-
handler = new MulticastParams.SequenceTopologyHandler(null, 1, 100, "test-${i}");
59+
handler = new MulticastParams.SequenceTopologyHandler(null, 1, 100, "test-%d");
6060
assertThat(handler.getQueueNames(), hasSize(100));
6161

6262
assertThat(handler.getRoutingKey(), is("test-1"));
@@ -76,4 +76,10 @@ public void reset() {
7676
assertThat(handler.getQueueNamesForClient(), allOf(iterableWithSize(1), hasItem("test-2")));
7777
assertThat(handler.getRoutingKey(), is("test-2"));
7878
}
79+
80+
@Test
81+
public void format() {
82+
handler = new MulticastParams.SequenceTopologyHandler(null, 1, 5, "test-%03d");
83+
assertThat(handler.getQueueNames(), allOf(iterableWithSize(5), hasItems("test-001", "test-002", "test-003", "test-004", "test-005")));
84+
}
7985
}

src/test/java/com/rabbitmq/perf/TopologyTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -336,11 +336,11 @@ public void differentMachinesConsumer() throws Exception {
336336
.queueBind(eq(queue), eq("direct"), eq(routingKey));
337337
}
338338

339-
// --queue-pattern 'perf-test-${i}' --from 1 --to 100
339+
// --queue-pattern 'perf-test-%d' --queue-pattern-from 1 --queue-pattern-to 100
340340
@Test
341341
public void sequenceQueuesDefinition1to100() throws Exception {
342342
String queuePrefix = "perf-test-";
343-
params.setQueuePattern(queuePrefix + "${i}");
343+
params.setQueuePattern(queuePrefix + "%d");
344344
params.setQueueSequenceFrom(1);
345345
params.setQueueSequenceTo(100);
346346

@@ -368,11 +368,11 @@ public void sequenceQueuesDefinition1to100() throws Exception {
368368
));
369369
}
370370

371-
// --queue-pattern 'perf-test-${i}' --from 100 --to 500
371+
// --queue-pattern 'perf-test-%d' --queue-pattern-from 100 --queue-pattern-to 500
372372
@Test
373373
public void sequenceQueuesDefinition100to500() throws Exception {
374374
String queuePrefix = "perf-test-";
375-
params.setQueuePattern(queuePrefix + "${i}");
375+
params.setQueuePattern(queuePrefix + "%d");
376376
params.setQueueSequenceFrom(100);
377377
params.setQueueSequenceTo(500);
378378

@@ -400,11 +400,11 @@ public void sequenceQueuesDefinition100to500() throws Exception {
400400
));
401401
}
402402

403-
// --queue-pattern 'perf-test-${i}' --from 502 --to 5001
403+
// --queue-pattern 'perf-test-%d' --queue-pattern-from 502 --queue-pattern-to 5001
404404
@Test
405405
public void sequenceQueuesDefinition502to5001() throws Exception {
406406
String queuePrefix = "perf-test-";
407-
params.setQueuePattern(queuePrefix + "${i}");
407+
params.setQueuePattern(queuePrefix + "%d");
408408
params.setQueueSequenceFrom(502);
409409
params.setQueueSequenceTo(5001);
410410

@@ -434,13 +434,13 @@ public void sequenceQueuesDefinition502to5001() throws Exception {
434434
));
435435
}
436436

437-
// --queue-pattern 'perf-test-${i}' --from 1 --to 100 --producers 10 --consumers 0
437+
// --queue-pattern 'perf-test-%d' --queue-pattern-from 1 --queue-pattern-to 100 --producers 10 --consumers 0
438438
@Test
439439
public void sequenceMoreQueuesThanProducers() throws Exception {
440440
String queuePrefix = "perf-test-";
441441
params.setConsumerCount(0);
442442
params.setProducerCount(10);
443-
params.setQueuePattern(queuePrefix + "${i}");
443+
params.setQueuePattern(queuePrefix + "%d");
444444
params.setQueueSequenceFrom(1);
445445
params.setQueueSequenceTo(100);
446446

@@ -475,13 +475,13 @@ public void sequenceMoreQueuesThanProducers() throws Exception {
475475
));
476476
}
477477

478-
// --queue-pattern 'perf-test-${i}' --from 1 --to 10 --producers 15 --consumers 30
478+
// --queue-pattern 'perf-test-%d' --queue-pattern-from 1 --queue-pattern-to 10 --producers 15 --consumers 30
479479
@Test
480480
public void sequenceProducersAndConsumersSpread() throws Exception {
481481
String queuePrefix = "perf-test-";
482482
params.setConsumerCount(30);
483483
params.setProducerCount(15);
484-
params.setQueuePattern(queuePrefix + "${i}");
484+
params.setQueuePattern(queuePrefix + "%d");
485485
params.setQueueSequenceFrom(1);
486486
params.setQueueSequenceTo(10);
487487

@@ -538,13 +538,13 @@ public void sequenceProducersAndConsumersSpread() throws Exception {
538538
));
539539
}
540540

541-
// --queue-pattern 'perf-test-${i}' --from 101 --to 110 --producers 0 --consumers 110
541+
// --queue-pattern 'perf-test-%d' --queue-pattern-from 101 --queue-pattern-to 110 --producers 0 --consumers 110
542542
@Test
543543
public void sequenceConsumersSpread() throws Exception {
544544
String queuePrefix = "perf-test-";
545545
params.setConsumerCount(110);
546546
params.setProducerCount(0);
547-
params.setQueuePattern(queuePrefix + "${i}");
547+
params.setQueuePattern(queuePrefix + "%d");
548548
params.setQueueSequenceFrom(101);
549549
params.setQueueSequenceTo(110);
550550

0 commit comments

Comments
 (0)