Skip to content

Commit 7d549f7

Browse files
committed
Fix completion-related tests
[#154470407] References #72
1 parent c3e89fc commit 7d549f7

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

src/main/java/com/rabbitmq/perf/Producer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ public Producer(Channel channel, String exchangeName, String id, boolean randomR
6464
long confirm, int confirmTimeout,
6565
MessageBodySource messageBodySource,
6666
TimestampProvider tsp, Stats stats, MulticastSet.CompletionHandler completionHandler) {
67-
6867
this.channel = channel;
6968
this.exchangeName = exchangeName;
7069
this.id = id;

src/test/java/com/rabbitmq/perf/MessageCountTimeLimitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public void producerCount(int producersCount, int channelsCount) throws Exceptio
169169
any(), any());
170170

171171
assertThat(messagesTotal + " messages should have been published by now",
172-
publishedLatch.await(5, TimeUnit.SECONDS), is(true));
172+
publishedLatch.await(10, TimeUnit.SECONDS), is(true));
173173
waitAtMost(5, TimeUnit.SECONDS).until(() -> runningTest.isDone(), is(true));
174174
verify(ch, times(messagesTotal))
175175
.basicPublish(anyString(), anyString(),

src/test/java/com/rabbitmq/perf/TopologyTest.java

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ public void sequenceMoreQueuesThanProducers() throws Exception {
471471
anyBoolean(), eq(false),
472472
any(), any(byte[].class));
473473

474-
MulticastSet set = getMulticastSet(new InterruptThreadHandler(latchPublishing));
474+
MulticastSet set = getMulticastSet(new MulticastSet.DefaultThreadingHandler(), latchPublishing);
475475

476476
set.run();
477477

@@ -617,14 +617,26 @@ private MulticastSet getMulticastSet() {
617617
private MulticastSet getMulticastSet(MulticastSet.ThreadingHandler threadingHandler) {
618618
MulticastSet set = new MulticastSet(
619619
stats, cf, params, singletonList("amqp://localhost"), new MulticastSet.CompletionHandler() {
620-
621620
@Override
622-
public void waitForCompletion() {
623-
}
621+
public void waitForCompletion() { }
622+
@Override
623+
public void countDown() { }
624+
}
625+
);
626+
627+
set.setThreadingHandler(threadingHandler);
628+
return set;
629+
}
624630

631+
private MulticastSet getMulticastSet(MulticastSet.ThreadingHandler threadingHandler, CountDownLatch completionLatch) {
632+
MulticastSet set = new MulticastSet(
633+
stats, cf, params, singletonList("amqp://localhost"), new MulticastSet.CompletionHandler() {
625634
@Override
626-
public void countDown() {
635+
public void waitForCompletion() throws InterruptedException {
636+
completionLatch.await(10, TimeUnit.SECONDS);
627637
}
638+
@Override
639+
public void countDown() { }
628640
}
629641
);
630642

0 commit comments

Comments
 (0)