Add timeout to rpc:multicall usage

Fixes #2437

Dependencies:

* rabbitmq/rabbitmq-common#410
* rabbitmq/rabbitmq-management-agent#96

(cherry picked from commit 201116b)

Author: lukebakken

src/rabbit_channel.erl

@@ -42,6 +42,8 @@
 
 -include_lib("rabbit_common/include/rabbit_framing.hrl").
 -include_lib("rabbit_common/include/rabbit.hrl").
+-include_lib("rabbit_common/include/rabbit_misc.hrl").
+
 -include("amqqueue.hrl").
 
 -behaviour(gen_server2).
@@ -352,8 +354,9 @@ send_drained(Pid, CTagCredit) ->
 -spec list() -> [pid()].
 
 list() ->
-    rabbit_misc:append_rpc_all_nodes(rabbit_mnesia:cluster_nodes(running),
-                                     rabbit_channel, list_local, []).
+    Running = rabbit_mnesia:cluster_nodes(running),
+    rabbit_misc:append_rpc_all_nodes(Running,
+                                     rabbit_channel, list_local, [], ?RPC_TIMEOUT).
 
 -spec list_local() -> [pid()].
 

src/rabbit_direct.erl

@@ -19,6 +19,7 @@
 -export([extract_extra_auth_props/4]).
 
 -include("rabbit.hrl").
+-include("rabbit_misc.hrl").
 
 %%----------------------------------------------------------------------------
 
@@ -43,8 +44,9 @@ list_local() ->
 -spec list() -> [pid()].
 
 list() ->
-    rabbit_misc:append_rpc_all_nodes(rabbit_mnesia:cluster_nodes(running),
-                                     rabbit_direct, list_local, []).
+    Running = rabbit_mnesia:cluster_nodes(running),
+    rabbit_misc:append_rpc_all_nodes(Running,
+                                     rabbit_direct, list_local, [], ?RPC_TIMEOUT).
 
 %%----------------------------------------------------------------------------
 

src/rabbit_networking.erl

@@ -47,6 +47,7 @@
 ]).
 
 -include("rabbit.hrl").
+-include("rabbit_misc.hrl").
 
 %% IANA-suggested ephemeral port range is 49152 to 65535
 -define(FIRST_TEST_BIND_PORT, 49152).
@@ -384,8 +385,9 @@ unregister_connection(Pid) -> pg_local:leave(rabbit_connections, Pid).
 -spec connections() -> [rabbit_types:connection()].
 
 connections() ->
-    rabbit_misc:append_rpc_all_nodes(rabbit_mnesia:cluster_nodes(running),
-                                     rabbit_networking, connections_local, []).
+    Running = rabbit_mnesia:cluster_nodes(running),
+    rabbit_misc:append_rpc_all_nodes(Running,
+                                     rabbit_networking, connections_local, [], ?RPC_TIMEOUT).
 
 -spec local_connections() -> [rabbit_types:connection()].
 %% @doc Returns pids of AMQP 0-9-1 and AMQP 1.0 connections local to this node.