Merge pull request #14860 from rabbitmq/fix-selenium-keycloak

Fix shellcheck warnings in selenium component scripts

Author: michaelklishin

selenium/bin/components/devkeycloak-proxy

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 HTTPD_DOCKER_IMAGE=${HTTPD_DOCKER_IMAGE:-httpd:latest}
 
 ensure_devkeycloak-proxy() {

selenium/bin/components/forward-proxy

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 HTTPD_DOCKER_IMAGE=${HTTPD_DOCKER_IMAGE:-httpd:latest}
 
 ensure_forward-proxy() {

selenium/bin/components/other-rabbitmq

@@ -69,7 +69,7 @@ start_local_other_rabbitmq() {
 
   print "> EFFECTIVE RABBITMQ_CONFIG_FILE: /tmp/other$MOUNT_RABBITMQ_CONF"
   cp ${RABBITMQ_CONFIG_DIR}/enabled_plugins /tmp/other/etc/rabbitmq/
-  RABBITMQ_ENABLED_PLUGINS=`cat /tmp/other/etc/rabbitmq/enabled_plugins | tr -d " \t\n\r" | awk -F'[][]' '{print $2}'`
+  RABBITMQ_ENABLED_PLUGINS=$(cat /tmp/other/etc/rabbitmq/enabled_plugins | tr -d " \t\n\r" | awk -F'[][]' '{print $2}')
   print "> EFFECTIVE PLUGINS: $RABBITMQ_ENABLED_PLUGINS"
 
   ${BIN_DIR}/gen-advanced-config "${PROFILES_FOR_OTHER}" ${RABBITMQ_CONFIG_DIR} $OTHER_ENV_FILE /tmp/other$MOUNT_ADVANCED_CONFIG

selenium/bin/components/prodkeycloak-proxy

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 HTTPD_DOCKER_IMAGE=${HTTPD_DOCKER_IMAGE:-httpd:latest}
 
 ensure_prodkeycloak-proxy() {
@@ -7,6 +9,7 @@ ensure_prodkeycloak-proxy() {
    start_prodkeycloak-proxy
  fi
 }
+
 init_prodkeycloak-proxy() {
   HTTPD_CONFIG_DIR=${TEST_CONFIG_DIR}/prodkeycloak-proxy
   PROXY_HOSTNAME=prodkeycloak-proxy 
@@ -17,6 +20,7 @@ init_prodkeycloak-proxy() {
   print "> PROXY_PORT: ${PROXY_PORT}"
 
   print "> HTTPD_DOCKER_IMAGE: ${HTTPD_DOCKER_IMAGE}"
+}
 
 start_prodkeycloak-proxy() {
   begin "Starting prodkeycloak-proxy ..."
@@ -27,7 +31,7 @@ start_prodkeycloak-proxy() {
   MOUNT_HTTPD_CONFIG_DIR=$CONF_DIR/httpd
 
   mkdir -p $MOUNT_HTTPD_CONFIG_DIR
-  ${BIN_DIR}/gen-httpd-conf ${HTTPD_CONFIG_DIR} $ENV_FILE $MOUNT_HTTPD_CONFIG_DIR/httpd.conf
+  ${BIN_DIR}/gen-httpd-conf" "${HTTPD_CONFIG_DIR} $ENV_FILE $MOUNT_HTTPD_CONFIG_DIR/httpd.conf
   print "> EFFECTIVE HTTPD_CONFIG_FILE: $MOUNT_HTTPD_CONFIG_DIR/httpd.conf"
   cp ${HTTPD_CONFIG_DIR}/.htpasswd $MOUNT_HTTPD_CONFIG_DIR
 

selenium/bin/components/proxy

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 HTTPD_DOCKER_IMAGE=${HTTPD_DOCKER_IMAGE:-httpd:latest}
 
 ensure_proxy() {

selenium/bin/components/rabbitmq

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
 
-SCRIPT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-
 
 init_rabbitmq() {
   RABBITMQ_CONFIG_DIR=${TEST_CONFIG_DIR}
@@ -70,7 +68,7 @@ start_local_rabbitmq() {
 
   print "> EFFECTIVE RABBITMQ_CONFIG_FILE: /tmp$MOUNT_RABBITMQ_CONF"
   cp ${RABBITMQ_CONFIG_DIR}/enabled_plugins /tmp/etc/rabbitmq/
-  RABBITMQ_ENABLED_PLUGINS=`cat /tmp/etc/rabbitmq/enabled_plugins | tr -d " \t\n\r" | awk -F'[][]' '{print $2}'`
+  RABBITMQ_ENABLED_PLUGINS=$(cat /tmp/etc/rabbitmq/enabled_plugins | tr -d " \t\n\r" | awk -F'[][]' '{print $2}')
   print "> EFFECTIVE PLUGINS: $RABBITMQ_ENABLED_PLUGINS"
 
   ${BIN_DIR}/gen-advanced-config "${PROFILES}" ${RABBITMQ_CONFIG_DIR} $ENV_FILE /tmp$MOUNT_ADVANCED_CONFIG