Make dialyzer happy

Author: mkuratczyk

deps/rabbit/src/rabbit_boot_steps.erl

@@ -47,7 +47,7 @@ find_steps(Apps) ->
     [Step || {App, _, _} = Step <- All, lists:member(App, Apps)].
 
 run_step(Attributes, AttributeName) ->
-    [begin
+    _ = [begin
         ?LOG_DEBUG("Applying MFA: M = ~ts, F = ~ts, A = ~tp",
                         [M, F, A]),
         case apply(M,F,A) of

deps/rabbit/src/rabbit_classic_queue.erl

@@ -589,7 +589,7 @@ recover_durable_queues(QueuesAndRecoveryTerms) ->
         gen_server2:mcall(
           [{rabbit_amqqueue_sup_sup:start_queue_process(node(), Q),
             {init, {self(), Terms}}} || {Q, Terms} <- QueuesAndRecoveryTerms]),
-    [?LOG_ERROR("Queue ~tp failed to initialise: ~tp",
+    _ = [?LOG_ERROR("Queue ~tp failed to initialise: ~tp",
                       [Pid, Error]) || {Pid, Error} <- Failures],
     [Q || {_, {new, Q}} <- Results].
 

deps/rabbit/src/rabbit_prelaunch_logging.erl

@@ -501,7 +501,7 @@ clear_config_run_number() ->
 -spec configure_logger(rabbit_env:context()) -> ok.
 
 configure_logger(Context) ->
-    logger:set_primary_config(metadata, #{domain => ?RMQLOG_DOMAIN_GLOBAL}),
+    _ = logger:set_primary_config(metadata, #{domain => ?RMQLOG_DOMAIN_GLOBAL}),
 
     %% Configure main handlers.
     %% We distinguish them by their type and possibly other

deps/rabbit/src/rabbit_quorum_queue.erl

@@ -2303,7 +2303,7 @@ transfer_leadership(_TransferCandidates) ->
     Queues = rabbit_amqqueue:list_local_leaders(),
     ?LOG_INFO("Will transfer leadership of ~b quorum queues with current leader on this node",
                     [length(Queues)]),
-    [begin
+    _ = [begin
         Name = amqqueue:get_name(Q),
         ?LOG_DEBUG("Will trigger a leader election for local quorum queue ~ts",
                          [rabbit_misc:rs(Name)]),
@@ -2326,7 +2326,7 @@ stop_local_quorum_queue_followers() ->
     Queues = rabbit_amqqueue:list_local_followers(),
     ?LOG_INFO("Will stop local follower replicas of ~b quorum queues on this node",
                     [length(Queues)]),
-    [begin
+    _ = [begin
         Name = amqqueue:get_name(Q),
         ?LOG_DEBUG("Will stop a local follower replica of quorum queue ~ts",
                          [rabbit_misc:rs(Name)]),

deps/rabbit/src/rabbit_vhosts.erl

@@ -115,7 +115,7 @@ start_processes_for_all(Nodes) ->
     Names = list_names(),
     N = length(Names),
     ?LOG_DEBUG("Will make sure that processes of ~p virtual hosts are running on all reachable cluster nodes", [N]),
-    [begin
+    _ = [begin
          try
              start_on_all_nodes(VH, Nodes)
          catch

deps/rabbitmq_consistent_hash_exchange/src/rabbit_exchange_type_consistent_hash.erl

@@ -143,7 +143,7 @@ recover_exchange_and_bindings(#exchange{name = XName} = X) ->
     Bindings = rabbit_binding:list_for_source(XName),
     ?LOG_DEBUG("Consistent hashing exchange: have ~b bindings to recover for exchange ~ts",
                      [length(Bindings), rabbit_misc:rs(XName)]),
-    [add_binding(none, X, B) || B <- lists:usort(Bindings)],
+    _ = [add_binding(none, X, B) || B <- lists:usort(Bindings)],
     ?LOG_DEBUG("Consistent hashing exchange: recovered bindings for exchange ~ts",
                      [rabbit_misc:rs(XName)]).
 
@@ -191,7 +191,7 @@ chx_hash_ring_update_fun(#chx_hash_ring{bucket_map = BM0,
 
 remove_bindings(_Serial, _X, Bindings) ->
     Ret = rabbit_db_ch_exchange:delete_bindings(Bindings, fun ch_hash_ring_delete_fun/2),
-    [?LOG_WARNING("Can't remove binding: hash ring state for exchange ~s wasn't found",
+    _ = [?LOG_WARNING("Can't remove binding: hash ring state for exchange ~s wasn't found",
                         [rabbit_misc:rs(X)]) || {not_found, X} <- Ret],
     ok.