Handle wrong scope_aliases configuration

Author: MarcialRosales

deps/rabbitmq_auth_backend_oauth2/src/rabbit_oauth2_schema.erl

@@ -52,8 +52,8 @@ extract_scope_aliases_as_list_of_alias_scope_props(Settings) ->
     List0 = [{Index, {list_to_atom(Attr), V}}
         || {[?AUTH_OAUTH2, ?SCOPE_ALIASES, Index, Attr], V} <- Settings ],
     List1 = maps:to_list(maps:groups_from_list(KeyFun, ValueFun, List0)),    
-    maps:from_list([ 
-        extract_scope_alias_mapping(Proplist) || {_, Proplist} <- List1]).
+    List2 = [extract_scope_alias_mapping(Proplist) || {_, Proplist} <- List1],
+    maps:from_list([ V || V <- List2, V =/= {}]).
 
 extract_scope_alias_mapping(Proplist) ->
     Alias = 
@@ -67,8 +67,14 @@ extract_scope_alias_mapping(Proplist) ->
             S -> convert_space_separated_string_to_list_of_binaries(S)
         end,
     case {Alias, Scope} of
-        {{error, _} = Err0, _} -> Err0;
-        {_, {error, _} = Err1 } -> Err1;
+        {{error, _} = Err0, _} -> 
+            rabbit_log:error("Skipped wrong scope_aliases configuration: ~p", 
+                [Err0]),
+            {};
+        {_, {error, _} = Err1 } -> 
+            rabbit_log:error("Skipped wrong scope_aliases configuration: ~p", 
+                [Err1]),
+            {};
         _ = V -> V
     end.
 

deps/rabbitmq_auth_backend_oauth2/test/rabbit_oauth2_schema_SUITE.erl

@@ -40,7 +40,8 @@ all() ->
         test_invalid_oauth_providers_endpoint_params,
         test_without_oauth_providers_with_endpoint_params,
         test_scope_aliases_configured_as_list_of_properties,
-        test_scope_aliases_configured_as_map
+        test_scope_aliases_configured_as_map,
+        test_scope_aliases_configured_as_list_of_missing_properties
     ].
 
 
@@ -298,6 +299,20 @@ test_scope_aliases_configured_as_list_of_properties(_) ->
         <<"developer">> := [<<"rabbitmq.tag:management">>, <<"rabbitmq.read:*/*">>]                         
     } = translate_scope_aliases(CuttlefishConf).
 
+test_scope_aliases_configured_as_list_of_missing_properties(_) ->
+    CuttlefishConf = [
+        {["auth_oauth2","scope_aliases","1","alias"],
+            "admin"}
+    ],
+    #{} = rabbit_oauth2_schema:translate_scope_aliases(CuttlefishConf),
+
+    CuttlefishConf2 = [
+        {["auth_oauth2","scope_aliases","1","scope"],
+            "rabbitmq.tag:management rabbitmq.read:*/*"}
+    ],
+    #{} = rabbit_oauth2_schema:translate_scope_aliases(CuttlefishConf2).
+
+        
 test_scope_aliases_configured_as_map(_) ->
     CuttlefishConf = [
         {["auth_oauth2","scope_aliases","admin"],