Improve test speed

Author: SimonUnge

deps/rabbit/test/node_initial_run_SUITE.erl

@@ -85,8 +85,8 @@ verify_initial_run_disabled(Config) ->
     ?assertNot(filelib:is_file(MarkerFile)),
 
     % Restarting the node should work fine
-    ok = rabbit_ct_broker_helpers:stop_node(Config, 0),
-    ok = rabbit_ct_broker_helpers:start_node(Config, 0),
+    ok = stop_app(Config),
+    ok = start_app(Config),
     % Still no marker file
     ?assertNot(filelib:is_file(MarkerFile)),
     ok.
@@ -100,28 +100,42 @@ verify_initial_run_enabled(Config) ->
 
     % Restarting the node should be fine, as there is a marker file
     % and corresponding schema data (consistent state)
-    ok = rabbit_ct_broker_helpers:stop_node(Config, 0),
-    ok = rabbit_ct_broker_helpers:start_node(Config, 0),
+    ok = stop_app(Config),
+    ok = start_app(Config),
 
     SchemaFile = schema_file(Config),
 
     ?assert(filelib:is_file(MarkerFile)),
 
     % Stop the node and remove the present schema to simulate data loss
-    ok = rabbit_ct_broker_helpers:stop_node(Config, 0),
+    ok = stop_app(Config),
     file:delete(SchemaFile),
     % Node should fail to start because marker exists but schema is missing,
     % indicating potential data loss or corruption
     ?assertMatch(
-        {error, {skip, "Failed to initialize RabbitMQ"}},
-        rabbit_ct_broker_helpers:start_node(Config, 0)
+        {error, 69, _},
+        start_app(Config)
     ),
     ok.
 
 %% -------------------------------------------------------------------
 %% Internal helpers
 %% -------------------------------------------------------------------
 
+stop_app(Config) ->
+    Node = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+    case rabbit_ct_broker_helpers:rabbitmqctl(Config, Node, ["stop_app"]) of
+        {ok, _} -> ok;
+        Error   -> Error
+    end.
+
+start_app(Config) ->
+    Node = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
+    case rabbit_ct_broker_helpers:rabbitmqctl(Config, Node, ["start_app"]) of
+        {ok, _} -> ok;
+        Error   -> Error
+    end.
+
 maybe_enable_verify_initial_run(Config, verify_initial_run_enabled) ->
     rabbit_ct_helpers:merge_app_env(
         Config, {rabbit, [{verify_initial_run, true}]}