Skip to content

Commit 23c714b

Browse files
committed
log bad ack tags if not found in backing queue state
1 parent bcf09a1 commit 23c714b

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

deps/rabbit/src/rabbit_variable_queue.erl

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -648,16 +648,21 @@ requeue(AckTags, #vqstate { delta = Delta,
648648
len = Len + MsgCount })))}.
649649

650650
ackfold(MsgFun, Acc, State, AckTags) ->
651-
{AccN, StateN} =
652-
lists:foldl(fun(SeqId, {Acc0, State0}) ->
651+
{AccN, StateN, BadAckTags} =
652+
lists:foldl(fun(SeqId, {Acc0, State0, BadAckTagsAcc}) ->
653653
case lookup_pending_ack(SeqId, State0) of
654654
none ->
655-
{Acc0, State0};
655+
{Acc0, State0, [SeqId | BadAckTagsAcc]};
656656
MsgStatus = #msg_status{} ->
657657
{Msg, State1} = read_msg(MsgStatus, State0),
658-
{MsgFun(Msg, SeqId, Acc0), State1}
658+
{MsgFun(Msg, SeqId, Acc0), State1, BadAckTagsAcc}
659659
end
660-
end, {Acc, State}, AckTags),
660+
end, {Acc, State, []}, AckTags),
661+
if length(BadAckTags) > 0 ->
662+
rabbit_log:warning("ack tags not found in ram_pending_ack and disk_pending_ack: ~tp", [BadAckTags]);
663+
true ->
664+
ok
665+
end,
661666
{AccN, a(StateN)}.
662667

663668
fold(Fun, Acc, State = #vqstate{index_state = IndexState}) ->

0 commit comments

Comments
 (0)