Skip test assertion

Not only are quorum queues wrongly implemented, but also classic queues
when draining in 3.13.

Like quorum queues, classsic queues reply with a send_drained event
before delivering the message(s).

Therefore, we have to skip the drain test in such mixed version
clusters where the leader runs on the old (3.13.1) node.

The new 4.0 implementation with credit API v2 fixes this bug.

Author: ansd

deps/rabbit/src/rabbit_amqp_session.erl

@@ -2090,7 +2090,6 @@ process_credit_reply_sync(
                      {queue_event,
                       QName,
                       {send_credit_reply, Avail}}} ->
-                        %% Convert to credit_api_v2 action.
                         Action = {credit_reply_v1, Ctag, Credit, Avail, false},
                         handle_queue_actions([Action], State)
             after ?CREDIT_REPLY_TIMEOUT ->

deps/rabbit/test/amqp_client_SUITE.erl

@@ -2465,12 +2465,8 @@ queue_and_client_different_nodes(QueueLeaderNode, ClientNode, QueueType, Config)
            true,
            accepted),
 
-    CreditApiV2 = rpc(Config, rabbit_feature_flags, is_enabled, [credit_api_v2]),
-    case QueueType =:= <<"quorum">> andalso not CreditApiV2 of
+    case rpc(Config, rabbit_feature_flags, is_enabled, [credit_api_v2]) of
         true ->
-            ct:pal("Quorum queues in credit API v1 have a known bug that they "
-                   "reply with send_drained before delivering the message.");
-        false ->
             %% Send another message and drain.
             Tag = <<"tag">>,
             Body = <<"body">>,
@@ -2482,7 +2478,11 @@ queue_and_client_different_nodes(QueueLeaderNode, ClientNode, QueueType, Config)
             receive {amqp10_event, {link, Receiver, credit_exhausted}} -> ok
             after 5000 -> ct:fail("expected credit_exhausted")
             end,
-            ok = amqp10_client:accept_msg(Receiver, Msg)
+            ok = amqp10_client:accept_msg(Receiver, Msg);
+        false ->
+            ct:pal("Both quorum queues and classic queues in credit API v1
+                   have a known bug that they reply with send_drained
+                   before delivering the message.")
     end,
 
     ExpectedReadyMsgs = 0,