Skip to content

Commit 28e117f

Browse files
committed
Default all rabbitmq_integration_suite to flaky in bazel
Most tests that can start rabbitmq nodes have some chance of flaking. Rather than chase individual flakes for now, this commit changes the default (though it can still be overriden, as is the case for config_scheme_SUITE in many places, since I have yet to see that particular suite flake). (cherry picked from commit 70cb814)
1 parent cf76e47 commit 28e117f

File tree

22 files changed

+30
-23
lines changed

22 files changed

+30
-23
lines changed

deps/rabbit/BUILD.bazel

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ rabbitmq_integration_suite(
347347
},
348348
"cluster_size_3": {
349349
"groups": ["cluster_size_3"],
350-
"flaky": True,
351350
},
352351
},
353352
)
@@ -362,7 +361,6 @@ rabbitmq_integration_suite(
362361
PACKAGE,
363362
name = "clustering_management_SUITE",
364363
size = "large",
365-
flaky = True,
366364
matrix = ct_group_matrix([
367365
"unclustered_2_nodes",
368366
"unclustered_3_nodes",
@@ -378,6 +376,7 @@ rabbitmq_integration_suite(
378376
data = [
379377
"test/definition_import_SUITE_data/case1.json",
380378
],
379+
flaky = False,
381380
)
382381

383382
rabbitmq_integration_suite(
@@ -408,7 +407,6 @@ rabbitmq_integration_suite(
408407
additional_beam = [
409408
":quorum_queue_utils",
410409
],
411-
flaky = True,
412410
)
413411

414412
rabbitmq_integration_suite(
@@ -479,7 +477,6 @@ rabbitmq_integration_suite(
479477
additional_beam = [
480478
":sync_detection_SUITE_beam_files",
481479
],
482-
flaky = True,
483480
matrix = ct_group_case_matrix({
484481
"non_parallel_tests": [
485482
"eager_sync",
@@ -525,7 +522,6 @@ rabbitmq_integration_suite(
525522
"enabling_in_cluster-enable_feature_flag_when_ff_file_is_unwritable": {
526523
"groups": ["enabling_in_cluster"],
527524
"cases": ["enable_feature_flag_when_ff_file_is_unwritable"],
528-
"flaky": True,
529525
# The enabling_* tests chmod files and then expect writes to be blocked.
530526
# This probably doesn't work because we are root in the remote docker image.
531527
"tags": ["exclusive"],
@@ -540,7 +536,6 @@ rabbitmq_integration_suite(
540536
},
541537
"clustering": {
542538
"groups": ["clustering"],
543-
"flaky": True,
544539
},
545540
"activating_plugin": {
546541
"groups": ["activating_plugin"],
@@ -626,7 +621,6 @@ rabbitmq_integration_suite(
626621
PACKAGE,
627622
name = "peer_discovery_classic_config_SUITE",
628623
size = "medium",
629-
flaky = True,
630624
matrix = ct_group_case_matrix({
631625
"non_parallel": [
632626
"successful_discovery",
@@ -773,7 +767,6 @@ rabbitmq_integration_suite(
773767
},
774768
"clustered-cluster_size_2": {
775769
"groups": ["cluster_size_2"],
776-
"flaky": True,
777770
},
778771
"clustered-cluster_size_3": {
779772
"groups": ["cluster_size_3"],

deps/rabbitmq_amqp1_0/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ rabbitmq_integration_suite(
8787
rabbitmq_integration_suite(
8888
PACKAGE,
8989
name = "system_SUITE",
90-
flaky = True,
9190
matrix = ct_group_matrix([
9291
"dotnet",
9392
"java",

deps/rabbitmq_auth_backend_cache/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_cache"
6565
rabbitmq_integration_suite(
6666
PACKAGE,
6767
name = "config_schema_SUITE",
68+
flaky = False,
6869
)
6970

7071
rabbitmq_integration_suite(

deps/rabbitmq_auth_backend_http/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ rabbitmq_suite(
8787
rabbitmq_integration_suite(
8888
PACKAGE,
8989
name = "config_schema_SUITE",
90+
flaky = False,
9091
)
9192

9293
rabbitmq_suite(

deps/rabbitmq_auth_backend_ldap/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_ldap"
8989
rabbitmq_integration_suite(
9090
PACKAGE,
9191
name = "config_schema_SUITE",
92+
flaky = False,
9293
)
9394

9495
rabbitmq_integration_suite(

deps/rabbitmq_auth_backend_oauth2/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ rabbitmq_integration_suite(
7373
rabbitmq_integration_suite(
7474
PACKAGE,
7575
name = "config_schema_SUITE",
76+
flaky = False,
7677
)
7778

7879
rabbitmq_integration_suite(

deps/rabbitmq_event_exchange/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ PACKAGE = "deps/rabbitmq_event_exchange"
4444
rabbitmq_integration_suite(
4545
PACKAGE,
4646
name = "config_schema_SUITE",
47+
flaky = False,
4748
)
4849

4950
rabbitmq_integration_suite(

deps/rabbitmq_federation/BUILD.bazel

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,10 @@ rabbitmq_integration_suite(
103103
additional_beam = [
104104
":rabbit_federation_test_util",
105105
],
106-
matrix = {
107-
"classic_queue": {
108-
"groups": ["classic_queue"],
109-
},
110-
"quorum_queue": {
111-
"groups": ["quorum_queue"],
112-
"flaky": True,
113-
},
114-
},
106+
matrix = ct_group_matrix([
107+
"classic_queue",
108+
"quorum_queue",
109+
]),
115110
)
116111

117112
rabbitmq_integration_suite(

deps/rabbitmq_management/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ rabbitmq_integration_suite(
125125
PACKAGE,
126126
name = "config_schema_SUITE",
127127
size = "small",
128+
flaky = False,
128129
)
129130

130131
rabbitmq_suite(

deps/rabbitmq_mqtt/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@ rabbitmq_integration_suite(
127127
rabbitmq_integration_suite(
128128
PACKAGE,
129129
name = "config_schema_SUITE",
130+
flaky = False,
130131
)
131132

132133
rabbitmq_integration_suite(
133134
PACKAGE,
134135
name = "java_SUITE",
135-
flaky = True,
136136
)
137137

138138
rabbitmq_suite(

0 commit comments

Comments
 (0)