Default all rabbitmq_integration_suite to flaky in bazel

HoloRin · HoloRin · commit 28e117f21ac1 · 2021-06-21T16:33:57.000+02:00
Most tests that can start rabbitmq nodes have some chance of flaking. Rather than chase individual flakes for now, this commit changes the default (though it can still be overriden, as is the case for config_scheme_SUITE in many places, since I have yet to see that particular suite flake). (cherry picked from commit 70cb814)
diff --git a/deps/rabbit/BUILD.bazel b/deps/rabbit/BUILD.bazel
@@ -347,7 +347,6 @@ rabbitmq_integration_suite(
         },
         "cluster_size_3": {
             "groups": ["cluster_size_3"],
-            "flaky": True,
         },
     },
 )
@@ -362,7 +361,6 @@ rabbitmq_integration_suite(
     PACKAGE,
     name = "clustering_management_SUITE",
     size = "large",
-    flaky = True,
     matrix = ct_group_matrix([
         "unclustered_2_nodes",
         "unclustered_3_nodes",
@@ -378,6 +376,7 @@ rabbitmq_integration_suite(
     data = [
         "test/definition_import_SUITE_data/case1.json",
     ],
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
@@ -408,7 +407,6 @@ rabbitmq_integration_suite(
     additional_beam = [
         ":quorum_queue_utils",
     ],
-    flaky = True,
 )
 
 rabbitmq_integration_suite(
@@ -479,7 +477,6 @@ rabbitmq_integration_suite(
     additional_beam = [
         ":sync_detection_SUITE_beam_files",
     ],
-    flaky = True,
     matrix = ct_group_case_matrix({
         "non_parallel_tests": [
             "eager_sync",
@@ -525,7 +522,6 @@ rabbitmq_integration_suite(
         "enabling_in_cluster-enable_feature_flag_when_ff_file_is_unwritable": {
             "groups": ["enabling_in_cluster"],
             "cases": ["enable_feature_flag_when_ff_file_is_unwritable"],
-            "flaky": True,
             # The enabling_* tests chmod files and then expect writes to be blocked.
             # This probably doesn't work because we are root in the remote docker image.
             "tags": ["exclusive"],
@@ -540,7 +536,6 @@ rabbitmq_integration_suite(
         },
         "clustering": {
             "groups": ["clustering"],
-            "flaky": True,
         },
         "activating_plugin": {
             "groups": ["activating_plugin"],
@@ -626,7 +621,6 @@ rabbitmq_integration_suite(
     PACKAGE,
     name = "peer_discovery_classic_config_SUITE",
     size = "medium",
-    flaky = True,
     matrix = ct_group_case_matrix({
         "non_parallel": [
             "successful_discovery",
@@ -773,7 +767,6 @@ rabbitmq_integration_suite(
         },
         "clustered-cluster_size_2": {
             "groups": ["cluster_size_2"],
-            "flaky": True,
         },
         "clustered-cluster_size_3": {
             "groups": ["cluster_size_3"],
diff --git a/deps/rabbitmq_amqp1_0/BUILD.bazel b/deps/rabbitmq_amqp1_0/BUILD.bazel
@@ -87,7 +87,6 @@ rabbitmq_integration_suite(
 rabbitmq_integration_suite(
     PACKAGE,
     name = "system_SUITE",
-    flaky = True,
     matrix = ct_group_matrix([
         "dotnet",
         "java",
diff --git a/deps/rabbitmq_auth_backend_cache/BUILD.bazel b/deps/rabbitmq_auth_backend_cache/BUILD.bazel
@@ -65,6 +65,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_cache"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_auth_backend_http/BUILD.bazel b/deps/rabbitmq_auth_backend_http/BUILD.bazel
@@ -87,6 +87,7 @@ rabbitmq_suite(
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_suite(
diff --git a/deps/rabbitmq_auth_backend_ldap/BUILD.bazel b/deps/rabbitmq_auth_backend_ldap/BUILD.bazel
@@ -89,6 +89,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_ldap"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_auth_backend_oauth2/BUILD.bazel b/deps/rabbitmq_auth_backend_oauth2/BUILD.bazel
@@ -73,6 +73,7 @@ rabbitmq_integration_suite(
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_event_exchange/BUILD.bazel b/deps/rabbitmq_event_exchange/BUILD.bazel
@@ -44,6 +44,7 @@ PACKAGE = "deps/rabbitmq_event_exchange"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_federation/BUILD.bazel b/deps/rabbitmq_federation/BUILD.bazel
@@ -103,15 +103,10 @@ rabbitmq_integration_suite(
     additional_beam = [
         ":rabbit_federation_test_util",
     ],
-    matrix = {
-        "classic_queue": {
-            "groups": ["classic_queue"],
-        },
-        "quorum_queue": {
-            "groups": ["quorum_queue"],
-            "flaky": True,
-        },
-    },
+    matrix = ct_group_matrix([
+        "classic_queue",
+        "quorum_queue",
+    ]),
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_management/BUILD.bazel b/deps/rabbitmq_management/BUILD.bazel
@@ -125,6 +125,7 @@ rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
     size = "small",
+    flaky = False,
 )
 
 rabbitmq_suite(
diff --git a/deps/rabbitmq_mqtt/BUILD.bazel b/deps/rabbitmq_mqtt/BUILD.bazel
@@ -127,12 +127,12 @@ rabbitmq_integration_suite(
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
     PACKAGE,
     name = "java_SUITE",
-    flaky = True,
 )
 
 rabbitmq_suite(
diff --git a/deps/rabbitmq_peer_discovery_aws/BUILD.bazel b/deps/rabbitmq_peer_discovery_aws/BUILD.bazel
@@ -62,6 +62,7 @@ rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
     size = "small",
+    flaky = False,
 )
 
 # NOTE: integration_SUITE requires aws credentials and a docker image.
diff --git a/deps/rabbitmq_peer_discovery_common/BUILD.bazel b/deps/rabbitmq_peer_discovery_common/BUILD.bazel
@@ -74,4 +74,5 @@ PACKAGE = "deps/rabbitmq_peer_discovery_common"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
diff --git a/deps/rabbitmq_peer_discovery_consul/BUILD.bazel b/deps/rabbitmq_peer_discovery_consul/BUILD.bazel
@@ -52,6 +52,7 @@ PACKAGE = "deps/rabbitmq_peer_discovery_consul"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_suite(
diff --git a/deps/rabbitmq_peer_discovery_etcd/BUILD.bazel b/deps/rabbitmq_peer_discovery_etcd/BUILD.bazel
@@ -54,6 +54,7 @@ PACKAGE = "deps/rabbitmq_peer_discovery_etcd"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_peer_discovery_k8s/BUILD.bazel b/deps/rabbitmq_peer_discovery_k8s/BUILD.bazel
@@ -52,6 +52,7 @@ PACKAGE = "deps/rabbitmq_peer_discovery_k8s"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_suite(
diff --git a/deps/rabbitmq_prometheus/BUILD.bazel b/deps/rabbitmq_prometheus/BUILD.bazel
@@ -56,11 +56,11 @@ PACKAGE = "deps/rabbitmq_prometheus"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
     PACKAGE,
     name = "rabbit_prometheus_http_SUITE",
     size = "small",
-    flaky = True,
 )
diff --git a/deps/rabbitmq_shovel/BUILD.bazel b/deps/rabbitmq_shovel/BUILD.bazel
@@ -141,7 +141,6 @@ rabbitmq_integration_suite(
     additional_beam = [
         ":shovel_test_utils",
     ],
-    flaky = True,
 )
 
 rabbitmq_suite(
diff --git a/deps/rabbitmq_stomp/BUILD.bazel b/deps/rabbitmq_stomp/BUILD.bazel
@@ -107,6 +107,7 @@ rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
     size = "small",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_trust_store/BUILD.bazel b/deps/rabbitmq_trust_store/BUILD.bazel
@@ -49,7 +49,10 @@ rabbitmq_lib(
     deps = DEPS,
 )
 
-xref(tags = ["xref"])
+xref(
+    size = "small",
+    tags = ["xref"],
+)
 
 plt(
     name = "base_plt",
@@ -58,6 +61,7 @@ plt(
 )
 
 dialyze(
+    size = "small",
     dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
     plt = ":base_plt",
     tags = ["dialyze"],
@@ -83,12 +87,13 @@ PACKAGE = "deps/rabbitmq_trust_store"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    size = "small",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
     PACKAGE,
     name = "system_SUITE",
-    flaky = True,
     matrix = ct_group_matrix([
         "file_provider_tests",
         "http_provider_tests",
diff --git a/deps/rabbitmq_web_mqtt/BUILD.bazel b/deps/rabbitmq_web_mqtt/BUILD.bazel
@@ -64,6 +64,7 @@ PACKAGE = "deps/rabbitmq_web_mqtt"
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/deps/rabbitmq_web_stomp/BUILD.bazel b/deps/rabbitmq_web_stomp/BUILD.bazel
@@ -88,6 +88,7 @@ rabbitmq_integration_suite(
 rabbitmq_integration_suite(
     PACKAGE,
     name = "config_schema_SUITE",
+    flaky = False,
 )
 
 rabbitmq_integration_suite(
diff --git a/rabbitmq.bzl b/rabbitmq.bzl
@@ -134,6 +134,7 @@ def rabbitmq_integration_suite(
         tools = [],
         deps = [],
         runtime_deps = [],
+        flaky = True,
         **kwargs):
     ct_suite(
         erlc_opts = RABBITMQ_TEST_ERLC_OPTS + erlc_opts,
@@ -163,5 +164,6 @@ def rabbitmq_integration_suite(
             "@lager//:bazel_erlang_lib",
             "@rabbitmq_ct_helpers//:bazel_erlang_lib",
         ] + deps,
+        flaky = flaky,
         **kwargs
     )

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_cache"`
`65`	`65`	`rabbitmq_integration_suite(`
`66`	`66`	`PACKAGE,`
`67`	`67`	`name = "config_schema_SUITE",`
	`68`	`+ flaky = False,`
`68`	`69`	`)`
`69`	`70`
`70`	`71`	`rabbitmq_integration_suite(`
Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,7 @@ rabbitmq_suite(`
`87`	`87`	`rabbitmq_integration_suite(`
`88`	`88`	`PACKAGE,`
`89`	`89`	`name = "config_schema_SUITE",`
	`90`	`+ flaky = False,`
`90`	`91`	`)`
`91`	`92`
`92`	`93`	`rabbitmq_suite(`
Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ PACKAGE = "deps/rabbitmq_auth_backend_ldap"`
`89`	`89`	`rabbitmq_integration_suite(`
`90`	`90`	`PACKAGE,`
`91`	`91`	`name = "config_schema_SUITE",`
	`92`	`+ flaky = False,`
`92`	`93`	`)`
`93`	`94`
`94`	`95`	`rabbitmq_integration_suite(`
Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@ rabbitmq_integration_suite(`
`73`	`73`	`rabbitmq_integration_suite(`
`74`	`74`	`PACKAGE,`
`75`	`75`	`name = "config_schema_SUITE",`
	`76`	`+ flaky = False,`
`76`	`77`	`)`
`77`	`78`
`78`	`79`	`rabbitmq_integration_suite(`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ PACKAGE = "deps/rabbitmq_event_exchange"`
`44`	`44`	`rabbitmq_integration_suite(`
`45`	`45`	`PACKAGE,`
`46`	`46`	`name = "config_schema_SUITE",`
	`47`	`+ flaky = False,`
`47`	`48`	`)`
`48`	`49`
`49`	`50`	`rabbitmq_integration_suite(`
Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ rabbitmq_integration_suite(`
`125`	`125`	`PACKAGE,`
`126`	`126`	`name = "config_schema_SUITE",`
`127`	`127`	`size = "small",`
	`128`	`+ flaky = False,`
`128`	`129`	`)`
`129`	`130`
`130`	`131`	`rabbitmq_suite(`
Original file line number	Diff line number	Diff line change
`@@ -127,12 +127,12 @@ rabbitmq_integration_suite(`
`127`	`127`	`rabbitmq_integration_suite(`
`128`	`128`	`PACKAGE,`
`129`	`129`	`name = "config_schema_SUITE",`
	`130`	`+ flaky = False,`
`130`	`131`	`)`
`131`	`132`
`132`	`133`	`rabbitmq_integration_suite(`
`133`	`134`	`PACKAGE,`
`134`	`135`	`name = "java_SUITE",`
`135`		`- flaky = True,`
`136`	`136`	`)`
`137`	`137`
`138`	`138`	`rabbitmq_suite(`