Merge pull request #8236 from rabbitmq/no-more-lazy

Remove "lazy" from Management and lazy-specific tests

Author: michaelklishin

deps/rabbit/BUILD.bazel

@@ -117,7 +117,6 @@ _APP_ENV = """[
 
 	    %% rabbitmq-server#973
 	    {queue_explicit_gc_run_operation_threshold, 1000},
-	    {lazy_queue_explicit_gc_run_operation_threshold, 1000},
 	    {background_gc_enabled, false},
 	    {background_gc_target_interval, 60000},
 	    %% rabbitmq-server#589
@@ -451,11 +450,6 @@ rabbitmq_integration_suite(
     ],
 )
 
-rabbitmq_integration_suite(
-    name = "lazy_queue_SUITE",
-    size = "medium",
-)
-
 rabbitmq_integration_suite(
     name = "list_consumers_sanity_check_SUITE",
     size = "medium",

deps/rabbit/Makefile

@@ -100,7 +100,6 @@ define PROJECT_ENV
 
 	    %% rabbitmq-server#973
 	    {queue_explicit_gc_run_operation_threshold, 1000},
-	    {lazy_queue_explicit_gc_run_operation_threshold, 1000},
 	    {background_gc_enabled, false},
 	    {background_gc_target_interval, 60000},
 	    %% rabbitmq-server#589
@@ -205,7 +204,6 @@ SLOW_CT_SUITES := backing_queue \
 		  eager_sync \
 		  feature_flags \
 		  health_check \
-		  lazy_queue \
 		  many_node_ha \
 		  metrics \
 		  msg_store \

deps/rabbit/app.bzl

@@ -942,15 +942,6 @@ def test_suite_beam_files(name = "test_suite_beam_files"):
         app_name = "rabbit",
         erlc_opts = "//:test_erlc_opts",
     )
-    erlang_bytecode(
-        name = "lazy_queue_SUITE_beam_files",
-        testonly = True,
-        srcs = ["test/lazy_queue_SUITE.erl"],
-        outs = ["test/lazy_queue_SUITE.beam"],
-        app_name = "rabbit",
-        erlc_opts = "//:test_erlc_opts",
-        deps = ["//deps/amqp_client:erlang_app"],
-    )
     erlang_bytecode(
         name = "list_consumers_sanity_check_SUITE_beam_files",
         testonly = True,

deps/rabbit/test/backing_queue_SUITE.erl

@@ -1,4 +1,4 @@
-%% This Source Code Form is subject to the terms of the Mozilla Public
+ % This Source Code Form is subject to the terms of the Mozilla Public
 %% License, v. 2.0. If a copy of the MPL was not distributed with this
 %% file, You can obtain one at https://mozilla.org/MPL/2.0/.
 %%
@@ -43,8 +43,6 @@
     bq_queue_index,
     bq_queue_index_props,
     {variable_queue_default, [parallel], ?VARIABLE_QUEUE_TESTCASES},
-    {variable_queue_lazy, [parallel], ?VARIABLE_QUEUE_TESTCASES ++
-                                      [variable_queue_mode_change]},
     bq_variable_queue_delete_msg_store_files_callback,
     bq_queue_recover
   ]).
@@ -142,8 +140,6 @@ init_per_group1(backing_queue_embed_limit_1024, Config) ->
     Config;
 init_per_group1(variable_queue_default, Config) ->
     rabbit_ct_helpers:set_config(Config, {variable_queue_type, default});
-init_per_group1(variable_queue_lazy, Config) ->
-    rabbit_ct_helpers:set_config(Config, {variable_queue_type, lazy});
 %% @todo These groups are no longer used?
 init_per_group1(from_cluster_node1, Config) ->
     rabbit_ct_helpers:set_config(Config, {test_direction, {0, 1}});

deps/rabbit/test/channel_operation_timeout_test_queue.erl

@@ -80,7 +80,7 @@
 
           io_batch_size,
 
-          %% default queue or lazy queue
+          %% default queue (or lazy queue from 3.6 to 3.11)
           mode,
           version = 1,
           %% Fast path for confirms handling. Instead of having

deps/rabbit/test/lazy_queue_SUITE.erl

@@ -225,9 +225,6 @@ var HELP = {
     'queue-max-age':
       'Sets the data retention for stream queues in time units </br>(Y=Years, M=Months, D=Days, h=hours, m=minutes, s=seconds).<br/>E.g. "1h" configures the stream to only keep the last 1 hour of received messages.</br></br>(Sets the x-max-age argument.)',
 
-    'queue-lazy':
-      'Set the queue into lazy mode, keeping as many messages as possible on disk to reduce RAM usage; if not set, the queue will keep an in-memory cache to deliver messages as fast as possible.<br/>(Sets the "<a target="_blank" href="https://www.rabbitmq.com/lazy-queues.html">x-queue-mode</a>" argument.)',
-
     'queue-version':
       'Set the queue version. Defaults to version 1.<br/>Version 1 has a journal-based index that embeds small messages.<br/>Version 2 has a different index which improves memory usage and performance in many scenarios, as well as a per-queue store for messages that were previously embedded.<br/>(Sets the "x-queue-version" argument.)',
 

deps/rabbitmq_management/priv/www/js/global.js

@@ -118,7 +118,6 @@
                   <span class="argument-link" field="definition" key="ha-promote-on-shutdown" type="string" value="">HA mirror promotion on shutdown</span> <span class="help" id="policy-ha-promote-on-shutdown"></span> |
                   <span class="argument-link" field="definition" key="ha-promote-on-failure" type="string" value="">HA mirror promotion on failure</span> <span class="help" id="policy-ha-promote-on-failure"></span>
                   </br>
-                  <span class="argument-link" field="definition" key="queue-mode" type="string" value="lazy">Lazy mode</span> |
                   <span class="argument-link" field="definition" key="queue-version" type="number">Version</span> <span class="help" id="queue-version"></span> |
                   <span class="argument-link" field="definition" key="queue-master-locator" type="string">Master locator</span></br>
                 </td>

deps/rabbitmq_management/priv/www/js/tmpl/policies.ejs

@@ -329,7 +329,6 @@
                   <span class="argument-link" field="arguments" key="x-max-length-bytes" type="number">Max length bytes</span> <span class="help" id="queue-max-length-bytes"></span><br/>
                 <% if (queue_type == "classic") { %>
                 <span class="argument-link" field="arguments" key="x-max-priority" type="number">Maximum priority</span> <span class="help" id="queue-max-priority"></span>
-                | <span class="argument-link" field="arguments" key="x-queue-mode" type="string" value="lazy">Lazy mode</span> <span class="help" id="queue-lazy"></span>
                 | <span class="argument-link" field="arguments" key="x-queue-version" type="number">Version</span> <span class="help" id="queue-version"></span>
                 | <span class="argument-link" field="arguments" key="x-queue-master-locator" type="string" value="">Master locator</span> <span class="help" id="queue-master-locator"></span>
                 <% } %>