Commit 32356ee
committed
rabbit_stream_queue_SUITE: Fix
[Why]
The previous detection was based on a reuse of the channel to get the
error from an exit exception. The problem is that it is very dependent
on the timing: if the channel process exits before it is reused, the
test fails for two possible reasons:
1. The channel and connection processes exit before they are reused and
the channel manager opens a new pair. The problem is that the declare
suceeds but the test expected a failure.
2. The channel and connection processes exit during the reuse and
`rabbit_ct_client_helpers:open_channel` in
`retry_if_coordinator_unavailable()` waits a response from the
channel manager forever (this is probably a weakness of the channel
manager in rabbitmq_ct_client_helpers). This indefinite wait causes
the testcase to timeout.
[How]
A simpler solution is to monitor the exit reason of the channel process
that triggers the error on the server side.consume_and_reject channel close detection1 parent 42746af commit 32356ee
1 file changed
+14
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1351 | 1351 | | |
1352 | 1352 | | |
1353 | 1353 | | |
| 1354 | + | |
1354 | 1355 | | |
1355 | 1356 | | |
1356 | | - | |
1357 | | - | |
1358 | | - | |
1359 | | - | |
1360 | | - | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
1361 | 1370 | | |
1362 | 1371 | | |
1363 | 1372 | | |
| |||
0 commit comments