Add a warning for invalid regular expressions

michaelklishin · mergify[bot] · commit 3aa5c48fde2d · 2023-04-27T13:30:33.000Z
Warn the user when filter expression does not compile to a regular expression. Part of #8008. (cherry picked from commit fe1fbb8) (cherry picked from commit f320dae)
diff --git a/deps/rabbitmq_management/priv/www/js/main.js b/deps/rabbitmq_management/priv/www/js/main.js
@@ -753,6 +753,7 @@ function url_pagination_template_context(template, context, defaultPage, default
     // assume a regular text filter
     var valid_regexp = is_valid_regexp(name_request);
     if (!valid_regexp) {
+        show_popup('warn', fmt_escape_html(`Expression '${name_request}' is not a valid regular expression, will perform a regular text query`));
         use_regex = false;
     }
     if (use_regex && valid_regexp) {

Original file line number	Diff line number	Diff line change
`@@ -753,6 +753,7 @@ function url_pagination_template_context(template, context, defaultPage, default`
`753`	`753`	`// assume a regular text filter`
`754`	`754`	`var valid_regexp = is_valid_regexp(name_request);`
`755`	`755`	`if (!valid_regexp) {`
	`756`	+ show_popup('warn', fmt_escape_html(`Expression '${name_request}' is not a valid regular expression, will perform a regular text query`));
`756`	`757`	`use_regex = false;`
`757`	`758`	`}`
`758`	`759`	`if (use_regex && valid_regexp) {`