CQ: Remove ability to change shared store index module

It will always use the ETS index. This change lets us
do optimisations that would otherwise not be possible,
including 81b2c39.

A small functional change is included in this commit:
we now always use ets:update_counter to update the
ref_count, instead of a mix of update_{counter,fields}.

When upgrading to 4.0, the index will be rebuilt for
all users that were using a custom index module.

Author: lhoguin

deps/rabbit/BUILD.bazel

@@ -39,7 +39,6 @@ _APP_ENV = """[
 	    {vm_memory_calculation_strategy, rss},
 	    {memory_monitor_interval, 2500},
 	    {disk_free_limit, 50000000}, %% 50MB
-	    {msg_store_index_module, rabbit_msg_store_ets_index},
 	    {backing_queue_module, rabbit_variable_queue},
 	    %% 0 ("no limit") would make a better default, but that
 	    %% breaks the QPid Java client

deps/rabbit/Makefile

@@ -19,7 +19,6 @@ define PROJECT_ENV
 	    {vm_memory_calculation_strategy, rss},
 	    {memory_monitor_interval, 2500},
 	    {disk_free_limit, 50000000}, %% 50MB
-	    {msg_store_index_module, rabbit_msg_store_ets_index},
 	    {backing_queue_module, rabbit_variable_queue},
 	    %% 0 ("no limit") would make a better default, but that
 	    %% breaks the QPid Java client

deps/rabbit/app.bzl

@@ -170,7 +170,6 @@ def all_beam_files(name = "all_beam_files"):
             "src/rabbit_mirror_queue_misc.erl",
             "src/rabbit_mnesia.erl",
             "src/rabbit_msg_store.erl",
-            "src/rabbit_msg_store_ets_index.erl",
             "src/rabbit_msg_store_gc.erl",
             "src/rabbit_networking.erl",
             "src/rabbit_networking_store.erl",
@@ -431,7 +430,6 @@ def all_test_beam_files(name = "all_test_beam_files"):
             "src/rabbit_mirror_queue_misc.erl",
             "src/rabbit_mnesia.erl",
             "src/rabbit_msg_store.erl",
-            "src/rabbit_msg_store_ets_index.erl",
             "src/rabbit_msg_store_gc.erl",
             "src/rabbit_networking.erl",
             "src/rabbit_networking_store.erl",
@@ -711,7 +709,6 @@ def all_srcs(name = "all_srcs"):
             "src/rabbit_mirror_queue_misc.erl",
             "src/rabbit_mnesia.erl",
             "src/rabbit_msg_store.erl",
-            "src/rabbit_msg_store_ets_index.erl",
             "src/rabbit_msg_store_gc.erl",
             "src/rabbit_networking.erl",
             "src/rabbit_networking_store.erl",

deps/rabbit/src/rabbit_msg_store.erl

@@ -91,7 +91,7 @@ end_per_suite(Config) ->
 init_per_group(Group, Config) ->
     case lists:member({group, Group}, all()) of
         true ->
-            ClusterSize = 2,
+            ClusterSize = 1,
             Config1 = rabbit_ct_helpers:set_config(Config, [
                 {rmq_nodename_suffix, Group},
                 {rmq_nodes_count, ClusterSize}

deps/rabbit/src/rabbit_msg_store_ets_index.erl

@@ -59,7 +59,6 @@ def all_beam_files(name = "all_beam_files"):
             "src/rabbit_json.erl",
             "src/rabbit_log.erl",
             "src/rabbit_misc.erl",
-            "src/rabbit_msg_store_index.erl",
             "src/rabbit_net.erl",
             "src/rabbit_nodes_common.erl",
             "src/rabbit_numerical.erl",
@@ -155,7 +154,6 @@ def all_test_beam_files(name = "all_test_beam_files"):
             "src/rabbit_json.erl",
             "src/rabbit_log.erl",
             "src/rabbit_misc.erl",
-            "src/rabbit_msg_store_index.erl",
             "src/rabbit_net.erl",
             "src/rabbit_nodes_common.erl",
             "src/rabbit_numerical.erl",
@@ -246,7 +244,6 @@ def all_srcs(name = "all_srcs"):
             "src/rabbit_json.erl",
             "src/rabbit_log.erl",
             "src/rabbit_misc.erl",
-            "src/rabbit_msg_store_index.erl",
             "src/rabbit_net.erl",
             "src/rabbit_nodes_common.erl",
             "src/rabbit_numerical.erl",

deps/rabbit/test/backing_queue_SUITE.erl

@@ -686,7 +686,6 @@ rabbit:
 - rabbit_mirror_queue_misc
 - rabbit_mnesia
 - rabbit_msg_store
-- rabbit_msg_store_ets_index
 - rabbit_msg_store_gc
 - rabbit_networking
 - rabbit_networking_store
@@ -802,7 +801,6 @@ rabbit_common:
 - rabbit_json
 - rabbit_log
 - rabbit_misc
-- rabbit_msg_store_index
 - rabbit_net
 - rabbit_nodes_common
 - rabbit_numerical