Skip to content

Commit 42786aa

Browse files
committed
Drop alias support
1 parent 3ec7ac2 commit 42786aa

File tree

3 files changed

+2
-62
lines changed

3 files changed

+2
-62
lines changed
Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1 @@
11
%% vim:ft=erlang:sw=4:et:
2-
3-
{mapping, "alias.$alias", "rabbitmqctl.aliases",
4-
[{datatype, string}]}.
5-
6-
{translation, "rabbitmqctl.aliases",
7-
fun(Conf) ->
8-
Aliases0 = cuttlefish_variable:filter_by_prefix("alias", Conf),
9-
Aliases1 = [{Alias, Value} || {["alias", Alias], Value} <- Aliases0],
10-
Aliases2 = rabbit_cli:translate_aliases(Aliases1),
11-
Aliases2
12-
end}.

deps/rabbit/src/rabbit_cli.erl

Lines changed: 2 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
-export([main/1,
77
merge_argparse_def/2,
8-
translate_aliases/1,
9-
handle_alias/1,
108
noop/1]).
119

1210
main(Args) ->
@@ -146,20 +144,9 @@ partial_parse(Args, ArgparseDef, Options, RemainingArgs) ->
146144

147145
get_final_argparse_def(#{argparse_def := PartialArgparseDef} = Context) ->
148146
maybe
149-
{ok, Aliases} ?= get_aliases(Context),
150147
{ok, FullArgparseDef} ?= get_full_argparse_def(Context),
151-
ArgparseDef1 = merge_argparse_def(PartialArgparseDef, Aliases),
152-
ArgparseDef2 = merge_argparse_def(ArgparseDef1, FullArgparseDef),
153-
{ok, ArgparseDef2}
154-
end.
155-
156-
get_aliases(#{config := Config}) ->
157-
Aliases = maps:get(aliases, Config, #{}),
158-
case Aliases =:= #{} of
159-
true ->
160-
{ok, #{}};
161-
false ->
162-
{ok, #{commands => Aliases}}
148+
ArgparseDef1 = merge_argparse_def(PartialArgparseDef, FullArgparseDef),
149+
{ok, ArgparseDef1}
163150
end.
164151

165152
get_full_argparse_def(#{connection := Connection}) ->
@@ -247,38 +234,6 @@ get_config_filename(unix) ->
247234
[XdgConfigHome, "rabbitmq", "rabbitmqctl.conf"]),
248235
ConfigFilename.
249236

250-
%% -------------------------------------------------------------------
251-
%% Aliases handling.
252-
%% -------------------------------------------------------------------
253-
254-
translate_aliases(Aliases) ->
255-
Aliases1 = maps:from_list(Aliases),
256-
Aliases2 = maps:map(
257-
fun(_Alias, CommandStr) ->
258-
Args = string:lexemes(CommandStr, " "),
259-
#{alias => Args,
260-
help => hidden,
261-
handler => {?MODULE, handle_alias}}
262-
end, Aliases1),
263-
Aliases2.
264-
265-
handle_alias(
266-
#{progname := Progname,
267-
argparse_def := ArgparseDef,
268-
arg_map := ArgMap,
269-
command := #{alias := Args}} = Context) ->
270-
Options = #{progname => Progname},
271-
case argparse:parse(Args, ArgparseDef, Options) of
272-
{ok, ArgMap1, CmdPath1, Command1} ->
273-
ArgMap2 = maps:merge(ArgMap1, ArgMap),
274-
Context1 = Context#{arg_map => ArgMap2,
275-
cmd_path => CmdPath1,
276-
command => Command1},
277-
rabbit_cli_commands:do_run_command(Context1);
278-
{error, _} = Error ->
279-
Error
280-
end.
281-
282237
%% -------------------------------------------------------------------
283238
%% Command execution.
284239
%% -------------------------------------------------------------------

deps/rabbit/src/rabbit_cli_commands.erl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,6 @@ run_command(Context) ->
123123
Reason
124124
end.
125125

126-
do_run_command(#{command := Command, arg_map := #{help := true}} = Context)
127-
when not is_map_key(alias, Command) ->
128-
rabbit_cli_io:display_help(Context),
129-
ok;
130126
do_run_command(#{command := #{handler := {Mod, Fun}}} = Context) ->
131127
erlang:apply(Mod, Fun, [Context]).
132128

0 commit comments

Comments
 (0)