feature_flags_SUITE: Check feature flag support state

... in addition to the fact they are disabled. Because a unsupported
feature flag is implicitly disabled.

(cherry picked from commit a53285e)

Author: dumbbell

test/feature_flags_SUITE.erl

@@ -611,18 +611,26 @@ clustering_ok_with_ff_disabled_everywhere(Config) ->
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
-        true  -> ?assertEqual([false, false],
-                              is_feature_flag_enabled(Config, ff_from_testsuite));
-        false -> ok
+        true ->
+            ?assertEqual([true, true],
+                         is_feature_flag_supported(Config, ff_from_testsuite)),
+            ?assertEqual([false, false],
+                         is_feature_flag_enabled(Config, ff_from_testsuite));
+        false ->
+            ok
     end,
 
     ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)),
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
-        true  -> ?assertEqual([false, false],
-                              is_feature_flag_enabled(Config, ff_from_testsuite));
-        false -> ok
+        true ->
+            ?assertEqual([true, true],
+                         is_feature_flag_supported(Config, ff_from_testsuite)),
+            ?assertEqual([false, false],
+                         is_feature_flag_enabled(Config, ff_from_testsuite));
+        false ->
+            ok
     end,
     ok.
 
@@ -637,18 +645,24 @@ clustering_ok_with_ff_enabled_on_some_nodes(Config) ->
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
-        true  -> ?assertEqual([true, false],
-                              is_feature_flag_enabled(Config, ff_from_testsuite));
-        false -> ok
+        true ->
+            ?assertEqual([true, true],
+                         is_feature_flag_supported(Config, ff_from_testsuite)),
+            ?assertEqual([true, false],
+                         is_feature_flag_enabled(Config, ff_from_testsuite));
+        false ->
+            ok
     end,
 
     ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)),
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
-        true  -> ?assertEqual([true, true],
-                              is_feature_flag_enabled(Config, ff_from_testsuite));
-        false -> ok
+        true ->
+            ?assertEqual([true, true],
+                         is_feature_flag_enabled(Config, ff_from_testsuite));
+        false ->
+            ok
     end,
     ok.
 
@@ -661,18 +675,22 @@ clustering_ok_with_ff_enabled_everywhere(Config) ->
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
-        true  -> ?assertEqual([true, true],
-                              is_feature_flag_enabled(Config, ff_from_testsuite));
-        false -> ok
+        true ->
+            ?assertEqual([true, true],
+                         is_feature_flag_enabled(Config, ff_from_testsuite));
+        false ->
+            ok
     end,
 
     ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)),
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
-        true  -> ?assertEqual([true, true],
-                              is_feature_flag_enabled(Config, ff_from_testsuite));
-        false -> ok
+        true ->
+            ?assertEqual([true, true],
+                         is_feature_flag_enabled(Config, ff_from_testsuite));
+        false ->
+            ok
     end,
     ok.