Skip to content

Commit 69a29f5

Browse files
dumbbellmergify[bot]
authored andcommitted
rabbit_feature_flags: Reset registry after copying feature states
[Why] The copy is likely to install a different list of enabled feature flags compared to the possibly loaded registry. Therefore it needs to be reset. [How] This is already the case, but the reset is done from the clustering code and not right after the copy, leaving a time frame where the feature states are inconsistent between the loaded registry and the on-disk record. This should be the responsibility of the Feature flags subsystem anyway. (cherry picked from commit 932a971) (cherry picked from commit 29c5ecb)
1 parent 4bea9fc commit 69a29f5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

deps/rabbit/src/rabbit_feature_flags.erl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,6 +1330,7 @@ copy_feature_states_after_reset(RemoteNode) ->
13301330
#{domain => ?RMQLOG_DOMAIN_FEAT_FLAGS}),
13311331
case do_write_enabled_feature_flags_list(EnabledFeatureNames) of
13321332
ok ->
1333+
ok = reset_registry(),
13331334
ok;
13341335
{error, Reason} ->
13351336
File = enabled_feature_flags_list_file(),

0 commit comments

Comments
 (0)