Skip to content

Commit 6cdde03

Browse files
Reduce verbosity of some log statements
1 parent 32c6d5e commit 6cdde03

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

deps/oauth2_client/src/oauth2_client.erl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
get_openid_configuration/2, get_openid_configuration/3,
1212
merge_openid_configuration/2,
1313
merge_oauth_provider/2,
14-
extract_ssl_options_as_list/1
14+
extract_ssl_options_as_list/1,
15+
format_ssl_options/1, format_oauth_provider/1, format_oauth_provider_id/1
1516
]).
1617

1718
-include("oauth2_client.hrl").
@@ -557,8 +558,7 @@ format_ssl_options(TlsOptions) ->
557558
[] -> 0;
558559
Certs -> length(Certs)
559560
end,
560-
lists:flatten(io_lib:format("{verify: ~p, fail_if_no_peer_cert: ~p, crl_check: ~p, " ++
561-
"depth: ~p, cacertfile: ~p, cacerts(count): ~p }", [
561+
lists:flatten(io_lib:format("{verify: ~p, fail_if_no_peer_cert: ~p, crl_check: ~p, depth: ~p, cacertfile: ~p, cacerts(count): ~p }", [
562562
proplists:get_value(verify, TlsOptions),
563563
proplists:get_value(fail_if_no_peer_cert, TlsOptions),
564564
proplists:get_value(crl_check, TlsOptions),

deps/rabbitmq_auth_backend_oauth2/src/rabbit_oauth2_config.erl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@ do_replace_signing_keys(SigningKeys, root) ->
155155
proplists:get_value(signing_keys, KeyConfig1, #{}),
156156
SigningKeys)} | KeyConfig1],
157157
application:set_env(?APP, key_config, KeyConfig2),
158-
rabbit_log:debug("Replacing signing keys ~p", [ KeyConfig2]),
158+
rabbit_log:debug("Replacing signing keys for key_config with ~p keys",
159+
[maps:size(SigningKeys)]),
159160
SigningKeys;
160161

161162
do_replace_signing_keys(SigningKeys, OauthProviderId) ->
@@ -168,7 +169,8 @@ do_replace_signing_keys(SigningKeys, OauthProviderId) ->
168169

169170
OauthProviders = maps:put(OauthProviderId, OauthProvider, OauthProviders0),
170171
application:set_env(?APP, oauth_providers, OauthProviders),
171-
rabbit_log:debug("Replacing signing keys for ~p -> ~p", [OauthProviderId, OauthProvider]),
172+
rabbit_log:debug("Replacing signing keys for ~p -> ~p with ~p keys",
173+
[OauthProviderId, OauthProvider, maps:size(SigningKeys)]),
172174
SigningKeys.
173175

174176

deps/rabbitmq_auth_backend_oauth2/src/uaa_jwt.erl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ add_signing_key(KeyId, Type, Value) ->
3333
update_jwks_signing_keys(#oauth_provider{id = Id, jwks_uri = JwksUrl,
3434
ssl_options = SslOptions}) ->
3535
rabbit_log:debug("Downloading signing keys from ~tp (TLS options: ~p)",
36-
[JwksUrl, SslOptions]),
36+
[JwksUrl, oauth2_client:format_ssl_options(SslOptions)]),
3737
case uaa_jwks:get(JwksUrl, SslOptions) of
3838
{ok, {_, _, JwksBody}} ->
3939
KeyList = maps:get(<<"keys">>,
4040
jose:decode(erlang:iolist_to_binary(JwksBody)), []),
4141
Keys = maps:from_list(lists:map(fun(Key) ->
4242
{maps:get(<<"kid">>, Key, undefined), {json, Key}} end, KeyList)),
43-
rabbit_log:debug("Downloaded signing keys ~tp", [Keys]),
43+
rabbit_log:debug("Downloaded ~p signing keys", [maps:size(Keys)]),
4444
case rabbit_oauth2_config:replace_signing_keys(Keys, Id) of
4545
{error, _} = Err -> Err;
4646
_ -> ok
@@ -63,7 +63,7 @@ decode_and_verify(Token) ->
6363

6464
decode_and_verify(Token, ResourceServerId, OAuthProviderId) ->
6565
rabbit_log:debug("Resolved resource_server_id: ~p -> oauth_provider_id: ~p",
66-
[ResourceServerId, OAuthProviderId]),
66+
[ResourceServerId, oauth2_client:format_oauth_provider_id(OAuthProviderId)]),
6767
case uaa_jwt_jwt:get_key_id(rabbit_oauth2_config:get_default_key(OAuthProviderId), Token) of
6868
{ok, KeyId} ->
6969
case get_jwk(KeyId, OAuthProviderId) of
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
export KEYCLOAK_URL=https://localhost:8443/realms/test
22
export OAUTH_PROVIDER_URL=https://localhost:8443/realms/test
3-
export OAUTH_PROVIDER_CA_CERT=test/oauth/keycloak/ca_certificate.pem
3+
export OAUTH_PROVIDER_CA_CERT=selenium/test/oauth/keycloak/ca_certificate.pem

0 commit comments

Comments
 (0)