Skip to content

Commit 73eb1e4

Browse files
dcorbachomergify[bot]
authored andcommitted
Test: verify just vhost folder, not whole directory
(cherry picked from commit 91bcdd9) (cherry picked from commit 7f07a9c) # Conflicts: # deps/rabbit/test/per_vhost_msg_store_SUITE.erl
1 parent 6863626 commit 73eb1e4

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

deps/rabbit/app.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,7 @@ def test_suite_beam_files(name = "test_suite_beam_files"):
10861086
outs = ["test/per_vhost_msg_store_SUITE.beam"],
10871087
app_name = "rabbit",
10881088
erlc_opts = "//:test_erlc_opts",
1089-
deps = ["//deps/amqp_client:erlang_app"],
1089+
deps = ["//deps/amqp_client:erlang_app", "//deps/rabbitmq_ct_helpers:erlang_app"],
10901090
)
10911091
erlang_bytecode(
10921092
name = "per_vhost_queue_limit_SUITE_beam_files",

deps/rabbit/test/per_vhost_msg_store_SUITE.erl

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
-include_lib("common_test/include/ct.hrl").
1111
-include_lib("amqp_client/include/amqp_client.hrl").
12+
-include_lib("rabbitmq_ct_helpers/include/rabbit_assert.hrl").
1213

1314
-compile(export_all).
1415

@@ -109,23 +110,16 @@ storage_deleted_on_vhost_delete(Config) ->
109110
Vhost1 = ?config(vhost1, Config),
110111
Channel1 = ?config(channel1, Config),
111112
Queue1 = declare_durable_queue(Channel1),
112-
FolderSize = get_global_folder_size(Config),
113+
FolderSize = get_folder_size(Vhost1, Config),
113114

114115
publish_persistent_messages(index, Channel1, Queue1),
115116
publish_persistent_messages(store, Channel1, Queue1),
116-
FolderSizeAfterPublish = get_global_folder_size(Config),
117-
118-
%% Total storage size increased
119-
true = (FolderSize < FolderSizeAfterPublish),
117+
?awaitMatch(true, get_folder_size(Vhost1, Config) > FolderSize, 30000),
120118

121119
ok = rabbit_ct_broker_helpers:delete_vhost(Config, Vhost1),
122120

123-
%% Total memory reduced
124-
FolderSizeAfterDelete = get_global_folder_size(Config),
125-
true = (FolderSizeAfterPublish > FolderSizeAfterDelete),
126-
127121
%% There is no Vhost1 folder
128-
0 = get_folder_size(Vhost1, Config).
122+
?awaitMatch(0, get_folder_size(Vhost1, Config), 30000).
129123

130124

131125
single_vhost_storage_delete_is_safe(Config) ->
@@ -192,10 +186,13 @@ folder_size(Dir) ->
192186
filelib:fold_files(Dir, ".*", true,
193187
fun(F,Acc) -> filelib:file_size(F) + Acc end, 0).
194188

189+
<<<<<<< HEAD
195190
get_global_folder_size(Config) ->
196191
BaseDir = rabbit_ct_broker_helpers:rpc(Config, 0, rabbit_mnesia, dir, []),
197192
folder_size(BaseDir).
198193

194+
=======
195+
>>>>>>> 7f07a9c230 (Test: verify just vhost folder, not whole directory)
199196
vhost_dir(Vhost, Config) ->
200197
rabbit_ct_broker_helpers:rpc(Config, 0,
201198
rabbit_vhost, msg_store_dir_path, [Vhost]).

0 commit comments

Comments
 (0)