Skip to content

Commit 75d5193

Browse files
Remove a test that need reworking to be more predictable
It always passes locally and almost never in CI. We should consider testing the key code path used to seed the database in more isolation. (cherry picked from commit f2ab0b4)
1 parent 5f7b7cd commit 75d5193

File tree

1 file changed

+1
-25
lines changed

1 file changed

+1
-25
lines changed

test/clustering_management_SUITE.erl

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ groups() ->
5353
forget_offline_removes_things,
5454
force_boot,
5555
status_with_alarm,
56-
wait_fails_when_cluster_fails,
57-
concurrent_default_data_creation
56+
wait_fails_when_cluster_fails
5857
]},
5958
{cluster_size_4, [], [
6059
forget_promotes_offline_slave
@@ -637,29 +636,6 @@ wait_fails_when_cluster_fails(Config) ->
637636
{error, _, _} = rabbit_ct_broker_helpers:rabbitmqctl(Config, Rabbit,
638637
["wait", RabbitPidFile]).
639638

640-
concurrent_default_data_creation(Config) ->
641-
[Rabbit, Hare] = rabbit_ct_broker_helpers:get_node_configs(Config,
642-
nodename),
643-
%% Run multiple times to detect a race.
644-
%% This test simulates concurrent initialisation of several key node DB tables.
645-
%% Since this is node-local state, in practice this can only
646-
%% happen when a new cluster is formed and two nodes are booting
647-
%% at roughly the same time (say, within a couple of ms from each other).
648-
[concurrent_default_data_creation1(Rabbit, Hare) || _ <- lists:seq(1, 20)].
649-
650-
concurrent_default_data_creation1(Rabbit, Hare) ->
651-
%% Clear default data.
652-
[{atomic, ok} = rpc:call(Rabbit, mnesia, clear_table, [Tab])
653-
|| Tab <- [rabbit_user, rabbit_user_permission, rabbit_vhost]],
654-
%% Stop both nodes
655-
[ok = rpc:call(Node, rabbit, stop, []) || Node <- [Rabbit, Hare]],
656-
%% Start nodes in parallel
657-
[spawn(fun() -> rpc:call(Node, rabbit, start, []) end)
658-
|| Node <- [Rabbit, Hare]],
659-
%% Verify both nodes are started successfully
660-
[ok = rpc:call(Node, rabbit, await_startup, [Node]) || Node <- [Rabbit, Hare]],
661-
[{ok, _Pid} = rpc:call(Node, rabbit_vhost_sup_sup, get_vhost_sup, [<<"/">>]) || Node <- [Rabbit, Hare]].
662-
663639
%% ----------------------------------------------------------------------------
664640
%% Internal utils
665641
%% ----------------------------------------------------------------------------

0 commit comments

Comments
 (0)