Skip to content

Commit 78d7041

Browse files
References #14327
1 parent 018c4b1 commit 78d7041

File tree

1 file changed

+28
-6
lines changed

1 file changed

+28
-6
lines changed

deps/rabbitmq_auth_backend_internal_loopback/CONTRIBUTING.md

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ Pull requests is the primary place of discussing code changes.
77

88
The process is fairly standard:
99

10+
* Make sure you (or your employer/client) [signs the Contributor License Agreement](https://github.com/rabbitmq/cla) if needed (see below)
1011
* Present your idea to the RabbitMQ core team using [GitHub Discussions](https://github.com/rabbitmq/rabbitmq-server/discussions) or [RabbitMQ community Discord server](https://rabbitmq.com/discord)
1112
* Fork the repository or repositories you plan on contributing to
1213
* Run `git clean -xfffd && gmake clean && gmake distclean && gmake` to build all subprojects from scratch
1314
* Create a branch with a descriptive name
1415
* Make your changes, run tests, ensure correct code formatting, commit with a [descriptive message](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), push to your fork
1516
* Submit pull requests with an explanation what has been changed and **why**
16-
* Submit a filled out and signed [Contributor Agreement](https://cla.pivotal.io/) if needed (see below)
1717
* Be patient. We will get to your pull request eventually
1818

1919

@@ -35,8 +35,8 @@ killall -9 beam.smp; killall -9 erl; killall -9 make; killall -9 epmd; killall -
3535
cd deps/rabbit
3636

3737
# cleans build artifacts
38-
git clean -xfffd
3938
gmake clean; gmake distclean
39+
git clean -xfffd
4040

4141
# builds the broker and all of its dependencies
4242
gmake
@@ -79,6 +79,27 @@ Or, with Nu shell:
7979
with-env {'RABBITMQ_METADATA_STORE': 'khepri'} { gmake ct-quorum_queue }
8080
```
8181

82+
### Running Mixed Version Tests
83+
84+
For some components, it's important to run tests in a mixed-version cluster, to make sure the upgrades
85+
are handled correctly. For example, you may want to make sure that the quorum_queue suite passes, when
86+
there's a mix of RabbitMQ 4.1 and 4.2 nodes in the cluster.
87+
88+
Here's how you can do that:
89+
90+
```shell
91+
# download the older version, eg:
92+
https://github.com/rabbitmq/rabbitmq-server/releases/download/v4.1.1/rabbitmq-server-generic-unix-4.1.1.tar.xz
93+
94+
# unpack it
95+
tar xf rabbitmq-server-generic-unix-4.1.1.tar.xz
96+
97+
# run the test with SECONDARY_DIST pointing at the extracted folder
98+
SECONDARY_DIST=rabbitmq_server-4.1.1 make -C deps/rabbit ct-quorum_queue
99+
```
100+
101+
Odd-numbered nodes (eg. 1 and 3) will be started using the main repository, while even-numbered nodes (eg. node 2)
102+
will run the older version.
82103

83104
## Running Single Nodes from Source
84105

@@ -192,10 +213,11 @@ See [CODE_OF_CONDUCT.md](./CODE_OF_CONDUCT.md).
192213

193214
## Contributor Agreement
194215

195-
If you want to contribute a non-trivial change, please submit a signed copy of our
196-
[Contributor Agreement](https://cla.pivotal.io/) around the time
197-
you submit your pull request. This will make it much easier (in some cases, possible)
198-
for the RabbitMQ team at Pivotal to merge your contribution.
216+
Before submitting your first pull request, please submit a signed copy of our
217+
[Contributor Agreement](https://github.com/rabbitmq/cla) over email to `teamrabbitmq </> gmail dot c0m` with the subject of "RabbitMQ CLA".
218+
219+
Team RabbitMQ will not be able to accept contributions from individuals and legal entities (companies, non-profits)
220+
that haven't signed the CLA.
199221

200222
## Where to Ask Questions
201223

0 commit comments

Comments
 (0)