Skip to content

Commit 7affc20

Browse files
committed
Shovel bugfix: set invalid delete-after and no-ack options for amqp10
1 parent 1b5f8c3 commit 7affc20

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

deps/rabbitmq_shovel/src/rabbit_shovel_parameters.erl

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ internal_owner(Def) ->
113113
validate_src(Def) ->
114114
case protocols(Def) of
115115
{amqp091, _} -> validate_amqp091_src(Def);
116-
{amqp10, _} -> [];
116+
{amqp10, _} -> validate_amqp10_src(Def);
117117
{local, _} -> validate_local_src(Def)
118118
end.
119119

@@ -137,6 +137,14 @@ validate_amqp091_src(Def) ->
137137
ok
138138
end].
139139

140+
validate_amqp10_src(Def) ->
141+
[case {pget(<<"src-delete-after">>, Def, pget(<<"delete-after">>, Def)), pget(<<"ack-mode">>, Def)} of
142+
{N, <<"no-ack">>} when is_integer(N) ->
143+
{error, "Cannot specify 'no-ack' and numerical 'delete-after'", []};
144+
_ ->
145+
ok
146+
end].
147+
140148
validate_local_src(Def) ->
141149
[case pget2(<<"src-exchange">>, <<"src-queue">>, Def) of
142150
zero -> {error, "Must specify 'src-exchange' or 'src-queue'", []};

0 commit comments

Comments
 (0)