Skip to content

Commit 7f09feb

Browse files
Ayanda-Dmergify[bot]
authored andcommitted
Update QQ force-shrink logging
(cherry picked from commit dd5ec3c) (cherry picked from commit 16170d0)
1 parent 598ecdd commit 7f09feb

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

deps/rabbit/src/rabbit_quorum_queue.erl

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1889,9 +1889,10 @@ notify_decorators(QName, F, A) ->
18891889
is_stateful() -> true.
18901890

18911891
force_shrink_member_to_current_member(VHost, Name) ->
1892-
rabbit_log:warning("Disaster recovery procedure: shrinking ~p queue at vhost ~p to a single node cluster", [Name, VHost]),
18931892
Node = node(),
18941893
QName = rabbit_misc:r(VHost, queue, Name),
1894+
QNameFmt = rabbit_misc:rs(QName),
1895+
rabbit_log:warning("Shrinking ~ts to a single node: ~ts", [QNameFmt, Node]),
18951896
case rabbit_amqqueue:lookup(QName) of
18961897
{ok, Q} when ?is_amqqueue(Q) ->
18971898
{RaName, _} = amqqueue:get_pid(Q),
@@ -1904,19 +1905,19 @@ force_shrink_member_to_current_member(VHost, Name) ->
19041905
end,
19051906
_ = rabbit_amqqueue:update(QName, Fun),
19061907
_ = [ra:force_delete_server(?RA_SYSTEM, {RaName, N}) || N <- OtherNodes],
1907-
rabbit_log:warning("Disaster recovery procedure: shrinking finished");
1908+
rabbit_log:warning("Shrinking ~ts finished", [QNameFmt]);
19081909
_ ->
1909-
rabbit_log:warning("Disaster recovery procedure: shrinking failed, queue ~p not found at vhost ~p", [Name, VHost]),
1910+
rabbit_log:warning("Shrinking failed, ~ts not found", [QNameFmt]),
19101911
{error, not_found}
19111912
end.
19121913

19131914
force_vhost_queues_shrink_member_to_current_member(VHost) when is_binary(VHost) ->
1914-
rabbit_log:warning("Disaster recovery procedure: shrinking all quorum queues in vhost ~tp to a single node cluster", [VHost]),
1915+
rabbit_log:warning("Shrinking all quorum queues in vhost '~ts' to a single node: ~ts", [VHost, node()]),
19151916
ListQQs = fun() -> rabbit_amqqueue:list(VHost) end,
19161917
force_all_queues_shrink_member_to_current_member(ListQQs).
19171918

19181919
force_all_queues_shrink_member_to_current_member() ->
1919-
rabbit_log:warning("Disaster recovery procedure: shrinking all quorum queues to a single node cluster"),
1920+
rabbit_log:warning("Shrinking all quorum queues to a single node: ~ts", [node()]),
19201921
ListQQs = fun() -> rabbit_amqqueue:list() end,
19211922
force_all_queues_shrink_member_to_current_member(ListQQs).
19221923

@@ -1926,7 +1927,7 @@ force_all_queues_shrink_member_to_current_member(ListQQFun) when is_function(Lis
19261927
QName = amqqueue:get_name(Q),
19271928
{RaName, _} = amqqueue:get_pid(Q),
19281929
OtherNodes = lists:delete(Node, get_nodes(Q)),
1929-
rabbit_log:warning("Disaster recovery procedure: shrinking queue ~p", [QName]),
1930+
rabbit_log:warning("Shrinking queue ~ts to a single node: ~ts", [rabbit_misc:rs(QName), Node]),
19301931
ok = ra_server_proc:force_shrink_members_to_current_member({RaName, Node}),
19311932
Fun = fun (QQ) ->
19321933
TS0 = amqqueue:get_type_state(QQ),
@@ -1936,7 +1937,7 @@ force_all_queues_shrink_member_to_current_member(ListQQFun) when is_function(Lis
19361937
_ = rabbit_amqqueue:update(QName, Fun),
19371938
_ = [ra:force_delete_server(?RA_SYSTEM, {RaName, N}) || N <- OtherNodes]
19381939
end || Q <- ListQQFun(), amqqueue:get_type(Q) == ?MODULE],
1939-
rabbit_log:warning("Disaster recovery procedure: shrinking finished"),
1940+
rabbit_log:warning("Shrinking finished"),
19401941
ok.
19411942

19421943
is_minority(All, Up) ->

0 commit comments

Comments
 (0)