wip

Author: dumbbell

deps/rabbitmq_management/priv/www/css/main.css

@@ -232,7 +232,7 @@ div.form-popup-help {
   width: 500px;
   z-index: 2;
 }
-p.warning, div.form-popup-warn { background: #FF9; }
+div.warning, p.warning, div.form-popup-warn { background: #FF9; }
 
 div.form-popup-options { z-index: 3; overflow:auto; max-height:95%; }
 
@@ -255,7 +255,14 @@ div.form-popup-options span:hover {
   cursor: pointer;
 }
 
-p.warning { padding: 15px; border-radius: 5px; -moz-border-radius: 5px; text-align: center; }
+div.warning, p.warning { padding: 15px; border-radius: 5px; -moz-border-radius: 5px; text-align: center; }
+div.warning {
+  margin: 15px 0;
+}
+
+div.warning button {
+  margin: auto;
+}
 
 .highlight { min-width: 120px; font-size: 120%; text-align:center; padding:10px; background-color: #ddd; margin: 0 20px 0 0; color: #888; border-radius: 5px; -moz-border-radius: 5px; }
 .highlight strong { font-size: 2em; display: block; color: #444; font-weight: normal; }

deps/rabbitmq_management/priv/www/js/tmpl/feature-flags.ejs

@@ -18,9 +18,15 @@
          }
        }
   if (needs_enabling) { %>
-     <p class="warning">
-        All stable feature flags must be enabled after completing an upgrade. Without enabling all flags, upgrading to future minor or major versions of RabbitMQ may not be possible. <a href="https://www.rabbitmq.com/feature-flags.html">[Learn more]</a>
-     </p>
+     <div id="ff-disabled-stable-warning" class="warning">
+         <p>
+         All stable feature flags must be enabled after completing an upgrade.
+         Without enabling all flags, upgrading to future minor or major versions
+         of RabbitMQ may not be possible.
+         <a href="https://www.rabbitmq.com/docs/feature-flags">[Learn more]</a>
+         </p>
+         <button id="ff-enable-all-button" onclick='enable_all_stable_feature_flags(this);'>Enable all stable feature flags</button>
+     </div>
   <% } %>
 <div class="section">
   <h2>Feature Flags</h2>
@@ -29,7 +35,36 @@
   <div class="updatable">
 <% if (nonreq_feature_flags.length > 0) { %>
 <script>
-function handle_feature_flag(checkbox, feature_flag) {
+var nonreq_feature_flags = <%= JSON.stringify(nonreq_feature_flags) %>;
+
+function enable_all_stable_feature_flags(button) {
+    button.disabled = true;
+
+    const event = new Event('change');
+    for (var i = 0; i < nonreq_feature_flags.length; i++) {
+        var feature_flag = nonreq_feature_flags[i];
+        if (feature_flag.stability == 'experimental' || feature_flag.state == 'enabled')
+            continue;
+
+        var checkbox = document.getElementById('ff-checkbox-' + feature_flag.name);
+        if (checkbox.disabled)
+            continue;
+
+        checkbox.dispatchEvent(event);
+    }
+}
+
+function lookup_feature_flag(feature_flag_name) {
+    for (var i = 0; i < nonreq_feature_flags.length; i++) {
+        var feature_flag = nonreq_feature_flags[i];
+        if (feature_flag.name == feature_flag_name)
+            return feature_flag;
+    }
+}
+
+function handle_feature_flag(checkbox, feature_flag_name) {
+    var feature_flag = lookup_feature_flag(feature_flag_name);
+
     checkbox.indeterminate = true;
     checkbox.disabled = true;
     checkbox.checked = false;
@@ -107,8 +142,6 @@ function handle_feature_flag(checkbox, feature_flag) {
 }
 
 function enable_feature_flag(checkbox, feature_flag) {
-    console.log('Enable', feature_flag);
-
     var url = 'api/feature-flags/' + feature_flag.name + '/enable';
     var params = {name: feature_flag.name};
 
@@ -120,9 +153,10 @@ function enable_feature_flag(checkbox, feature_flag) {
         },
         body: JSON.stringify(params),
     }).then((resp) => {
-        console.log(resp);
         if (resp.ok) {
             checkbox.checked = true;
+
+            feature_flag.state = 'enabled';
         } else {
             checkbox.checked = false;
             checkbox.disabled = false;
@@ -132,6 +166,18 @@ function enable_feature_flag(checkbox, feature_flag) {
             });
         }
         checkbox.indeterminate = false;
+    }).then(() => {
+        for (var i = 0; i < nonreq_feature_flags.length; i++) {
+            var feature_flag = nonreq_feature_flags[i];
+            if (feature_flag.stability != 'experimental' && feature_flag.state == 'disabled') {
+                var button = document.getElementById('ff-enable-all-button');
+                button.disabled = false;
+                return;
+            }
+        }
+
+        var warning = document.getElementById('ff-disabled-stable-warning');
+        warning.style.display = 'none';
     });
 }
 </script>
@@ -215,9 +261,7 @@ function enable_feature_flag(checkbox, feature_flag) {
                   <% if (feature_flag.state == 'enabled') { %>
                   checked disabled
                   <% } %>
-                  onchange='handle_feature_flag(
-                              this,
-                              <%= JSON.stringify(feature_flag) %>);'/>
+                  onchange='handle_feature_flag(this, "<%= feature_flag.name %>");'/>
            <label for="ff-checkbox-<%= feature_flag.name %>" class="toggle"/>
          </td>
          <td>