Refactor constant and remove log statements

Author: MarcialRosales

deps/rabbitmq_management/include/rabbit_mgmt.hrl

@@ -14,4 +14,5 @@
 
 -define(MANAGEMENT_DEFAULT_HTTP_MAX_BODY_SIZE, 20000000).
 
--define(OAUTH2_ACCESS_TOKEN_COOKIE, <<"access_token">>).
+-define(OAUTH2_ACCESS_TOKEN_COOKIE_NAME, <<"access_token">>).
+-define(OAUTH2_ACCESS_TOKEN_COOKIE_PATH, "/js/oidc-oauth/bootstrap.js").

deps/rabbitmq_management/src/rabbit_mgmt_login.erl

@@ -24,13 +24,12 @@ login(<<"POST">>, Req0=#{scheme := Scheme}, State) ->
         {true, Req1, _} ->     
             CookieSettings = #{
                 http_only => true,
-                path => "/js/oidc-oauth/bootstrap.js",
+                path => ?OAUTH2_ACCESS_TOKEN_COOKIE_PATH,
                 max_age => 30,
                 expires => os:system_time(millisecond) + 30000,
                 same_site => strict
             },          
-            rabbit_log:debug("Setting access_token in cookie: ~p", [AccessToken]),
-            SetCookie = cowboy_req:set_resp_cookie(?OAUTH2_ACCESS_TOKEN_COOKIE, AccessToken, Req1,
+            SetCookie = cowboy_req:set_resp_cookie(?OAUTH2_ACCESS_TOKEN_COOKIE_NAME, AccessToken, Req1,
                 case Scheme of 
                     <<"https">> -> CookieSettings#{ secure => true};
                     _ -> CookieSettings

deps/rabbitmq_management/src/rabbit_mgmt_oauth_bootstrap.erl

@@ -37,23 +37,21 @@ set_token_auth(AuthSettings, Req0) ->
         true ->
             case cowboy_req:parse_header(<<"authorization">>, Req0) of
                 {bearer, Token} -> 
-                    rabbit_log:debug("Request contained token in authorization header"),
                     {
                         Req0, 
                         ["set_token_auth('", Token, "');"]
                     };
                 _ -> 
                     Cookies = cowboy_req:parse_cookies(Req0),
-                    case lists:keyfind(?OAUTH2_ACCESS_TOKEN_COOKIE, 1, Cookies) of 
+                    case lists:keyfind(?OAUTH2_ACCESS_TOKEN_COOKIE_NAME, 1, Cookies) of 
                         {_, Token} -> 
-                            rabbit_log:debug("Request contained token in cookie: ~p", [Token]),
                             {
                                 cowboy_req:set_resp_cookie(
-                                    ?OAUTH2_ACCESS_TOKEN_COOKIE, <<"">>, Req0, #{
+                                    ?OAUTH2_ACCESS_TOKEN_COOKIE_NAME, <<"">>, Req0, #{
                                         max_age => 0,
                                         expires => os:system_time(millisecond) - 30000,
                                         http_only => true,
-                                        path => "/js/oidc-oauth/bootstrap.js",
+                                        path => ?OAUTH2_ACCESS_TOKEN_COOKIE_PATH,
                                         same_site => strict
                                     }), 
                                 ["set_token_auth('", Token, "');"]