Skip to content

Commit 940e58c

Browse files
Test comment wording
1 parent 1e44604 commit 940e58c

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

deps/rabbit/test/quorum_queue_member_reconciliation_SUITE.erl

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ groups() ->
3434
[
3535
{quorum_queue_3, [], [auto_grow, auto_grow_drained_node, auto_shrink]}
3636
]},
37-
{unclustered_triggers, [], %% large interval (larger than `wait_until`(30sec))
38-
[ %% could pass only if triggers work, see also `auto_grow_drained_node`
37+
%% uses an interval longer than `wait_until` (30s by default)
38+
{unclustered_triggers, [],
39+
[
40+
%% see also `auto_grow_drained_node`
3941
{quorum_queue_3, [], [auto_grow, auto_shrink]}
4042
]}
4143
].
@@ -205,15 +207,14 @@ auto_shrink(Config) ->
205207
3 =:= length(M)
206208
end),
207209

208-
%% The logic of reconciliator is interesting - when it is triggered it actually postpones
209-
%% any action untill trigger_interval.
210-
%% So if this test wants to test that reconciliator reacts to node_down or similar
211-
%% it has to wait at least trigger_interval before removing node. Otherwise
212-
%% the shrink effect would come from the previous trigger (which in our case is queue declaration)
210+
%% QQ member reconciliation does not act immediately but rather after a scheduled delay.
211+
%% So if this test wants to test that the reconciliator reacts to, say, node_down or a similar event,
212+
%% it has to wait at least a trigger_interval ms to pass before removing node. Otherwise
213+
%% the shrink effect would come from the previous trigger.
213214
%%
214-
%% The key here is that when `queue_created` trigger switches timer to trigger_interval the queue has 3 nodes
215-
%% and at least locally stop_app works fast enough so that when trigger_interval elapsed, the number of Members
216-
%% will be changed without any need for node_down.
215+
%% When a `queue_created` trigger set up a timer to fire after a trigger_interval, the queue has 3 members
216+
%% and stop_app executes much quicker than the trigger_interval. Therefore the number of members
217+
%% will be updated even without a node_down event.
217218

218219
timer:sleep(rabbit_ct_helpers:get_config(Config, shrink_timeout, 0)),
219220

0 commit comments

Comments
 (0)