Fix Cowboy crashes caused by double reply

Issue introduced in 383ddb1.

Author: lhoguin

deps/rabbitmq_management/src/rabbit_mgmt_wm_exchange_publish.erl

@@ -30,10 +30,10 @@ content_types_provided(ReqData, Context) ->
    {rabbit_mgmt_util:responder_map(to_json), ReqData, Context}.
 
 resource_exists(ReqData, Context) ->
-    {case rabbit_mgmt_wm_exchange:exchange(ReqData) of
-         not_found -> raise_not_found(ReqData, Context);
-         _         -> true
-     end, ReqData, Context}.
+    case rabbit_mgmt_wm_queue:queue(ReqData) of
+        not_found -> {false, set_resp_not_found(ReqData), Context};
+        _         -> {true, ReqData, Context}
+    end.
 
 allow_missing_post(ReqData, Context) ->
     {false, ReqData, Context}.
@@ -104,17 +104,19 @@ bad({{coordinator_unavailable, _}, _}, ReqData, Context) ->
 is_authorized(ReqData, Context) ->
     rabbit_mgmt_util:is_authorized_vhost(ReqData, Context).
 
-raise_not_found(ReqData, Context) ->
+set_resp_not_found(ReqData) ->
     ErrorMessage = case rabbit_mgmt_util:vhost(ReqData) of
         not_found ->
-            "vhost_not_found";
+            <<"vhost_not_found">>;
         _ ->
-            "exchange_not_found"
+            <<"exchange_not_found">>
     end,
-    rabbit_mgmt_util:not_found(
-        rabbit_data_coercion:to_binary(ErrorMessage),
-        ReqData,
-        Context).
+    ReqData1 = cowboy_req:set_resp_header(
+        <<"content-type">>, <<"application/json">>, ReqData),
+    cowboy_req:set_resp_body(rabbit_json:encode(#{
+        <<"error">> => <<"not_found">>,
+        <<"reason">> => ErrorMessage
+    }), ReqData1).
 
 %%--------------------------------------------------------------------
 

deps/rabbitmq_management/src/rabbit_mgmt_wm_queue_actions.erl

@@ -26,10 +26,10 @@ allowed_methods(ReqData, Context) ->
     {[<<"POST">>, <<"OPTIONS">>], ReqData, Context}.
 
 resource_exists(ReqData, Context) ->
-    {case rabbit_mgmt_wm_queue:queue(ReqData) of
-         not_found -> raise_not_found(ReqData, Context);
-         _         -> true
-     end, ReqData, Context}.
+    case rabbit_mgmt_wm_queue:queue(ReqData) of
+        not_found -> {false, set_resp_not_found(ReqData), Context};
+        _         -> {true, ReqData, Context}
+    end.
 
 allow_missing_post(ReqData, Context) ->
     {false, ReqData, Context}.
@@ -54,17 +54,20 @@ do_it(ReqData0, Context) ->
 is_authorized(ReqData, Context) ->
     rabbit_mgmt_util:is_authorized_admin(ReqData, Context).
 
-raise_not_found(ReqData, Context) ->
+set_resp_not_found(ReqData) ->
     ErrorMessage = case rabbit_mgmt_util:vhost(ReqData) of
         not_found ->
-            "vhost_not_found";
+            <<"vhost_not_found">>;
         _ ->
-            "queue_not_found"
+            <<"queue_not_found">>
     end,
-    rabbit_mgmt_util:not_found(
-        rabbit_data_coercion:to_binary(ErrorMessage),
-        ReqData,
-        Context).
+    ReqData1 = cowboy_req:set_resp_header(
+        <<"content-type">>, <<"application/json">>, ReqData),
+    cowboy_req:set_resp_body(rabbit_json:encode(#{
+        <<"error">> => <<"not_found">>,
+        <<"reason">> => ErrorMessage
+    }), ReqData1).
+
 %%--------------------------------------------------------------------
 
 action(Else, _Q, ReqData, Context) ->

deps/rabbitmq_management/src/rabbit_mgmt_wm_queue_get.erl

@@ -30,10 +30,10 @@ content_types_provided(ReqData, Context) ->
    {rabbit_mgmt_util:responder_map(to_json), ReqData, Context}.
 
 resource_exists(ReqData, Context) ->
-    {case rabbit_mgmt_wm_queue:queue(ReqData) of
-         not_found -> raise_not_found(ReqData, Context);
-         _         -> true
-     end, ReqData, Context}.
+    case rabbit_mgmt_wm_queue:queue(ReqData) of
+        not_found -> {false, set_resp_not_found(ReqData), Context};
+        _         -> {true, ReqData, Context}
+    end.
 
 allow_missing_post(ReqData, Context) ->
     {false, ReqData, Context}.
@@ -152,17 +152,20 @@ basic_get(Ch, Q, AckMode, Enc, Trunc) ->
 is_authorized(ReqData, Context) ->
     rabbit_mgmt_util:is_authorized_vhost(ReqData, Context).
 
-raise_not_found(ReqData, Context) ->
+set_resp_not_found(ReqData) ->
     ErrorMessage = case rabbit_mgmt_util:vhost(ReqData) of
         not_found ->
-            "vhost_not_found";
+            <<"vhost_not_found">>;
         _ ->
-            "queue_not_found"
+            <<"queue_not_found">>
     end,
-    rabbit_mgmt_util:not_found(
-        rabbit_data_coercion:to_binary(ErrorMessage),
-        ReqData,
-        Context).
+    ReqData1 = cowboy_req:set_resp_header(
+        <<"content-type">>, <<"application/json">>, ReqData),
+    cowboy_req:set_resp_body(rabbit_json:encode(#{
+        <<"error">> => <<"not_found">>,
+        <<"reason">> => ErrorMessage
+    }), ReqData1).
+
 %%--------------------------------------------------------------------
 
 maybe_truncate(Payload, none)                         -> Payload;