Skip to content

Commit ad27625

Browse files
Fix issues
1 parent 90d05ac commit ad27625

File tree

3 files changed

+22
-18
lines changed

3 files changed

+22
-18
lines changed

deps/rabbitmq_management/priv/www/js/oidc-oauth/helper.js

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -290,19 +290,24 @@ export function oauth_completeLogin() {
290290

291291
export function oauth_initiateLogout() {
292292
if (oauth.sp_initiated) {
293-
return mgr.getUser().then(User => {
294-
mgr.metadataService.getEndSessionEndpoint().then(endpoint => {
295-
if (endpoint == undefined) {
296-
// Logout only from management UI
297-
mgr.removeUser().then(res => {
298-
clear_auth()
299-
oauth_redirectToLogin()
300-
})
301-
}else {
302-
// OpenId Connect RP-Initiated Logout
303-
mgr.signoutRedirect()
304-
}
305-
})
293+
return mgr.getUser().then(user => {
294+
if (user != null) {
295+
mgr.metadataService.getEndSessionEndpoint().then(endpoint => {
296+
if (endpoint == undefined) {
297+
// Logout only from management UI
298+
mgr.removeUser().then(res => {
299+
clear_auth()
300+
oauth_redirectToLogin()
301+
})
302+
}else {
303+
// OpenId Connect RP-Initiated Logout
304+
mgr.signoutRedirect()
305+
}
306+
})
307+
}else {
308+
clear_auth()
309+
go_to_home()
310+
}
306311
})
307312

308313
} else {

selenium/suites/authnz-mgt/oauth-and-basic-auth.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ SCRIPT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
44

55
TEST_CASES_PATH=/oauth/with-basic-auth
66
TEST_CONFIG_PATH=/oauth
7-
PROFILES="keycloak jwks keycloak-oauth-provider enable-basic-auth tls"
7+
PROFILES="keycloak keycloak-oauth-provider keycloak-mgt-oauth-provider tls enable-basic-auth"
88

99
source $SCRIPT/../../bin/suite_template $@
1010
runWith keycloak

selenium/test/oauth/with-basic-auth-idp-down/happy-login.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { By, Key, until, Builder } = require('selenium-webdriver')
22
require('chromedriver')
33
const assert = require('assert')
4-
const { buildDriver, goToHome, captureScreensFor, teardown, idpLoginPage } = require('../../utils')
4+
const { buildDriver, goToHome, captureScreensFor, teardown, idpLoginPage, delay } = require('../../utils')
55

66
const SSOHomePage = require('../../pageobjects/SSOHomePage')
77
const OverviewPage = require('../../pageobjects/OverviewPage')
@@ -24,9 +24,8 @@ describe('When basic authentication is enabled but UAA is down', function () {
2424
it('can log in with Basic Auth', async function () {
2525
await homePage.toggleBasicAuthSection()
2626
await homePage.basicAuthLogin('guest', 'guest')
27-
if (!await overview.isLoaded()) {
28-
throw new Error('Failed to login')
29-
}
27+
await overview.isLoaded()
28+
assert.equal(await overview.getUser(), 'User guest')
3029
await overview.logout()
3130
})
3231

0 commit comments

Comments
 (0)