rabbit_khepri: Avoid throws in register_projection/0

Previously this function threw errors. With this minor refactor we
return them instead so that `register_projection/0` is easier for
callers to work with.

Author: the-mikedavis

deps/rabbit/src/rabbit_khepri.erl

@@ -306,6 +306,9 @@ wait_for_leader(Timeout, Retries) ->
             throw(Reason)
     end.
 
+-spec wait_for_register_projections() -> Ret when
+      Ret :: ok | no_return().
+
 wait_for_register_projections() ->
     wait_for_register_projections(retry_timeout(), retry_limit()).
 
@@ -314,10 +317,10 @@ wait_for_register_projections(_Timeout, 0) ->
 wait_for_register_projections(Timeout, Retries) ->
     rabbit_log:info("Waiting for Khepri projections for ~tp ms, ~tp retries left",
                     [Timeout, Retries - 1]),
-    try
-        register_projections()
-    catch
-        throw : timeout ->
+    case register_projections() of
+        ok ->
+            ok;
+        {error, timeout} ->
             wait_for_register_projections(Timeout, Retries -1)
     end.
 
@@ -1091,6 +1094,9 @@ if_has_data_wildcard() ->
 if_has_data(Conditions) ->
     #if_all{conditions = Conditions ++ [#if_has_data{has_data = true}]}.
 
+-spec register_projections() -> Ret when
+      Ret :: ok | timeout_error().
+
 register_projections() ->
     RegisterFuns = [fun register_rabbit_exchange_projection/0,
                     fun register_rabbit_queue_projection/0,
@@ -1101,20 +1107,23 @@ register_projections() ->
                     fun register_rabbit_bindings_projection/0,
                     fun register_rabbit_index_route_projection/0,
                     fun register_rabbit_topic_graph_projection/0],
-    [case RegisterFun() of
-         ok ->
-             ok;
-         %% Before Khepri v0.13.0, `khepri:register_projection/1,2,3` would
-         %% return `{error, exists}` for projections which already exist.
-         {error, exists} ->
-             ok;
-         %% In v0.13.0+, Khepri returns a `?khepri_error(..)` instead.
-         {error, {khepri, projection_already_exists, _Info}} ->
-             ok;
-         {error, Error} ->
-             throw(Error)
-     end || RegisterFun <- RegisterFuns],
-    ok.
+    rabbit_misc:for_each_while_ok(
+      fun(RegisterFun) ->
+              case RegisterFun() of
+                  ok ->
+                      ok;
+                  %% Before Khepri v0.13.0, `khepri:register_projection/1,2,3`
+                  %% would return `{error, exists}` for projections which
+                  %% already exist.
+                  {error, exists} ->
+                      ok;
+                  %% In v0.13.0+, Khepri returns a `?khepri_error(..)` instead.
+                  {error, {khepri, projection_already_exists, _Info}} ->
+                      ok;
+                  {error, _} = Err ->
+                      Err
+              end
+      end, RegisterFuns).
 
 register_rabbit_exchange_projection() ->
     Name = rabbit_khepri_exchange,