Skip to content

Commit b930ba4

Browse files
author
Matthew Sackman
committed
Reintroduced traces of tcp_listeners where it turns out to be a jolly good idea, but don't set either one unless the other has been set. Thus if neither has been set then we don't do nowt.
1 parent 81bd9ff commit b930ba4

File tree

5 files changed

+76
-1
lines changed

5 files changed

+76
-1
lines changed

scripts/rabbitmq-multi

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,25 @@
3030
## Contributor(s): ______________________________________.
3131
##
3232
NODENAME=rabbit
33+
NODE_IP_ADDRESS=0.0.0.0
34+
NODE_PORT=5672
3335
SCRIPT_HOME=$(dirname $0)
3436
PIDS_FILE=/var/lib/rabbitmq/pids
3537
MULTI_ERL_ARGS=
3638
MULTI_START_ARGS=
3739

3840
. `dirname $0`/rabbitmq-env
3941

42+
if [ "x" = "x$RABBITMQ_NODE_IP_ADDRESS" ]
43+
then
44+
if [ "x" != "x$RABBITMQ_NODE_PORT" ]
45+
then RABBITMQ_NODE_IP_ADDRESS=${NODE_IP_ADDRESS}
46+
fi
47+
else
48+
if [ "x" = "x$RABBITMQ_NODE_PORT" ]
49+
then RABBITMQ_NODE_PORT=${NODE_PORT}
50+
fi
51+
fi
4052
[ "x" = "x$RABBITMQ_NODENAME" ] && RABBITMQ_NODENAME=${NODENAME}
4153
[ "x" = "x$RABBITMQ_SCRIPT_HOME" ] && RABBITMQ_SCRIPT_HOME=${SCRIPT_HOME}
4254
[ "x" = "x$RABBITMQ_PIDS_FILE" ] && RABBITMQ_PIDS_FILE=${PIDS_FILE}
@@ -45,6 +57,8 @@ MULTI_START_ARGS=
4557

4658
export \
4759
RABBITMQ_NODENAME \
60+
RABBITMQ_NODE_IP_ADDRESS \
61+
RABBITMQ_NODE_PORT \
4862
RABBITMQ_SCRIPT_HOME \
4963
RABBITMQ_PIDS_FILE
5064

scripts/rabbitmq-multi.bat

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,16 @@ if "%RABBITMQ_NODENAME%"=="" (
4040
set RABBITMQ_NODENAME=rabbit
4141
)
4242

43+
if "%RABBITMQ_NODE_IP_ADDRESS%"=="" (
44+
if not "%RABBITMQ_NODE_PORT%"=="" (
45+
set RABBITMQ_NODE_IP_ADDRESS=0.0.0.0
46+
)
47+
) else (
48+
if "%RABBITMQ_NODE_PORT%"=="" (
49+
set RABBITMQ_NODE_PORT=5672
50+
)
51+
)
52+
4353
set RABBITMQ_PIDS_FILE=%RABBITMQ_BASE%\rabbitmq.pids
4454
set RABBITMQ_SCRIPT_HOME=%~sdp0%
4555

scripts/rabbitmq-server

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
##
3232

3333
NODENAME=rabbit
34+
NODE_IP_ADDRESS=0.0.0.0
35+
NODE_PORT=5672
3436
SERVER_ERL_ARGS="+K true +A30 \
3537
-kernel inet_default_listen_options [{nodelay,true},{sndbuf,16384},{recbuf,4096}] \
3638
-kernel inet_default_connect_options [{nodelay,true}]"
@@ -42,6 +44,17 @@ SERVER_START_ARGS=
4244

4345
. `dirname $0`/rabbitmq-env
4446

47+
48+
if [ "x" = "x$RABBITMQ_NODE_IP_ADDRESS" ]
49+
then
50+
if [ "x" != "x$RABBITMQ_NODE_PORT" ]
51+
then RABBITMQ_NODE_IP_ADDRESS=${NODE_IP_ADDRESS}
52+
fi
53+
else
54+
if [ "x" = "x$RABBITMQ_NODE_PORT" ]
55+
then RABBITMQ_NODE_PORT=${NODE_PORT}
56+
fi
57+
fi
4558
[ "x" = "x$RABBITMQ_NODENAME" ] && RABBITMQ_NODENAME=${NODENAME}
4659
[ "x" = "x$RABBITMQ_SERVER_ERL_ARGS" ] && RABBITMQ_SERVER_ERL_ARGS=${SERVER_ERL_ARGS}
4760
[ "x" = "x$RABBITMQ_CLUSTER_CONFIG_FILE" ] && RABBITMQ_CLUSTER_CONFIG_FILE=${CLUSTER_CONFIG_FILE}
@@ -85,6 +98,9 @@ fi
8598
RABBITMQ_CONFIG_ARG=
8699
[ -f "${RABBITMQ_CONFIG_FILE}.config" ] && RABBITMQ_CONFIG_ARG="-config ${RABBITMQ_CONFIG_FILE}"
87100

101+
RABBITMQ_LISTEN_ARG=
102+
[ "x" != "x$RABBITMQ_NODE_PORT" ] && [ "x" != "x$RABBITMQ_NODE_IP_ADDRESS" ] && RABBITMQ_LISTEN_ARG="-rabbit tcp_listeners '[{"'${RABBITMQ_NODE_IP_ADDRESS}'", '${RABBITMQ_NODE_PORT}'}]'"
103+
88104
# we need to turn off path expansion because some of the vars, notably
89105
# RABBITMQ_SERVER_ERL_ARGS, contain terms that look like globs and
90106
# there is no other way of preventing their expansion.
@@ -98,6 +114,7 @@ exec erl \
98114
${RABBITMQ_CONFIG_ARG} \
99115
+W w \
100116
${RABBITMQ_SERVER_ERL_ARGS} \
117+
${RABBITMQ_LISTEN_ARG} \
101118
-sasl errlog_type error \
102119
-kernel error_logger '{file,"'${RABBITMQ_LOGS}'"}' \
103120
-sasl sasl_error_logger '{file,"'${RABBITMQ_SASL_LOGS}'"}' \

scripts/rabbitmq-server.bat

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,16 @@ if "%RABBITMQ_NODENAME%"=="" (
4040
set RABBITMQ_NODENAME=rabbit
4141
)
4242

43+
if "%RABBITMQ_NODE_IP_ADDRESS%"=="" (
44+
if not "%RABBITMQ_NODE_PORT%"=="" (
45+
set RABBITMQ_NODE_IP_ADDRESS=0.0.0.0
46+
)
47+
) else (
48+
if "%RABBITMQ_NODE_PORT%"=="" (
49+
set RABBITMQ_NODE_PORT=5672
50+
)
51+
)
52+
4353
if not exist "%ERLANG_HOME%\bin\erl.exe" (
4454
echo.
4555
echo ******************************
@@ -113,6 +123,13 @@ if exist "%RABBITMQ_CONFIG_FILE%.config" (
113123
set RABBITMQ_CONFIG_ARG=
114124
)
115125

126+
set RABBITMQ_LISTEN_ARG=
127+
if not "%RABBITMQ_NODE_IP_ADDRESS%"=="" (
128+
if not "%RABBITMQ_NODE_PORT%"=="" (
129+
set RABBITMQ_LISTEN_ARG=-rabbit tcp_listeners "[{\"%RABBITMQ_NODE_IP_ADDRESS%\", %RABBITMQ_NODE_PORT%}]"
130+
)
131+
)
132+
116133
"%ERLANG_HOME%\bin\erl.exe" ^
117134
%RABBITMQ_EBIN_PATH% ^
118135
-noinput ^
@@ -124,6 +141,7 @@ if exist "%RABBITMQ_CONFIG_FILE%.config" (
124141
+A30 ^
125142
-kernel inet_default_listen_options "[{nodelay, true}, {sndbuf, 16384}, {recbuf, 4096}]" ^
126143
-kernel inet_default_connect_options "[{nodelay, true}]" ^
144+
%RABBITMQ_LISTEN_ARG% ^
127145
-kernel error_logger {file,\""%RABBITMQ_LOG_BASE%/%RABBITMQ_NODENAME%.log"\"} ^
128146
%RABBITMQ_SERVER_ERL_ARGS% ^
129147
-sasl errlog_type error ^

scripts/rabbitmq-service.bat

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,16 @@ if "%RABBITMQ_NODENAME%"=="" (
4444
set RABBITMQ_NODENAME=rabbit
4545
)
4646

47+
if "%RABBITMQ_NODE_IP_ADDRESS%"=="" (
48+
if not "%RABBITMQ_NODE_PORT%"=="" (
49+
set RABBITMQ_NODE_IP_ADDRESS=0.0.0.0
50+
)
51+
) else (
52+
if "%RABBITMQ_NODE_PORT%"=="" (
53+
set RABBITMQ_NODE_PORT=5672
54+
)
55+
)
56+
4757
if "%ERLANG_SERVICE_MANAGER_PATH%"=="" (
4858
set ERLANG_SERVICE_MANAGER_PATH=C:\Program Files\erl5.6.5\erts-5.6.5\bin
4959
)
@@ -169,7 +179,12 @@ if exist "%RABBITMQ_CONFIG_FILE%.config" (
169179
set RABBITMQ_CONFIG_ARG=
170180
)
171181

172-
182+
set RABBITMQ_LISTEN_ARG=
183+
if not "%RABBITMQ_NODE_IP_ADDRESS%"=="" (
184+
if not "%RABBITMQ_NODE_PORT%"=="" (
185+
set RABBITMQ_LISTEN_ARG=-rabbit tcp_listeners "[{\"%RABBITMQ_NODE_IP_ADDRESS%\", %RABBITMQ_NODE_PORT%}]"
186+
)
187+
)
173188

174189
set ERLANG_SERVICE_ARGUMENTS= ^
175190
%RABBITMQ_EBIN_PATH% ^
@@ -180,6 +195,7 @@ set ERLANG_SERVICE_ARGUMENTS= ^
180195
+A30 ^
181196
-kernel inet_default_listen_options "[{nodelay,true},{sndbuf,16384},{recbuf,4096}]" ^
182197
-kernel inet_default_connect_options "[{nodelay,true}]" ^
198+
%RABBITMQ_LISTEN_ARG% ^
183199
-kernel error_logger {file,\""%RABBITMQ_LOG_BASE%/%RABBITMQ_NODENAME%.log"\"} ^
184200
%RABBITMQ_SERVER_ERL_ARGS% ^
185201
-sasl errlog_type error ^

0 commit comments

Comments
 (0)