Skip to content

Commit bc7a8be

Browse files
Move test to v5
because it is a feature exclusive of v5
1 parent 57ef5ea commit bc7a8be

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,7 @@ cluster_size_1_tests() ->
112112
,keepalive_turned_off
113113
,block
114114
,amqp_to_mqtt_qos0
115-
,clean_session_disconnect_client
116-
,zero_session_expiry_interval_disconnect_client
115+
,clean_session_disconnect_client
117116
,clean_session_node_restart
118117
,clean_session_node_kill
119118
,rabbit_status_connection_count
@@ -1586,18 +1585,6 @@ clean_session_disconnect_client(Config) ->
15861585
L = rpc(Config, rabbit_amqqueue, list, []),
15871586
?assertEqual(0, length(L)).
15881587

1589-
zero_session_expiry_interval_disconnect_client(Config) ->
1590-
C = connect(?FUNCTION_NAME, Config, [{properties, #{'Session-Expiry-Interval' => 0}}]),
1591-
{ok, _, _} = emqtt:subscribe(C, <<"topic0">>, qos0),
1592-
QsQos0 = rpc(Config, rabbit_amqqueue, list_by_type, [rabbit_mqtt_qos0_queue]),
1593-
?assertEqual(1, length(QsQos0)),
1594-
1595-
ok = emqtt:disconnect(C),
1596-
%% After terminating a clean session, we expect any session state to be cleaned up on the server.
1597-
timer:sleep(200), %% Give some time to clean up exclusive classic queue.
1598-
L = rpc(Config, rabbit_amqqueue, list, []),
1599-
?assertEqual(0, length(L)).
1600-
16011588
clean_session_node_restart(Config) ->
16021589
clean_session_node_down(stop_node, Config).
16031590

deps/rabbitmq_mqtt/test/v5_SUITE.erl

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ cluster_size_1_tests() ->
7171
session_expiry_reconnect_non_zero,
7272
session_expiry_reconnect_zero,
7373
session_expiry_reconnect_infinity_to_zero,
74+
zero_session_expiry_disconnect_autodeletes_qos0_queue,
7475
client_publish_qos2,
7576
client_rejects_publish,
7677
client_receive_maximum_min,
@@ -188,6 +189,12 @@ init_per_testcase(T, Config)
188189
ok = rpc(Config, application, set_env, [?APP, Par, infinity]),
189190
Config1 = rabbit_ct_helpers:set_config(Config, {Par, Default}),
190191
init_per_testcase0(T, Config1);
192+
193+
init_per_testcase(T, Config)
194+
when T =:= zero_session_expiry_disconnect_autodeletes_qos0_queue ->
195+
rpc(Config, rabbit_registry, register, [queue, <<"qos0">>, rabbit_mqtt_qos0_queue]),
196+
init_per_testcase0(T, Config);
197+
191198
init_per_testcase(T, Config) ->
192199
init_per_testcase0(T, Config).
193200

@@ -202,6 +209,11 @@ end_per_testcase(T, Config)
202209
Default = ?config(Par, Config),
203210
ok = rpc(Config, application, set_env, [?APP, Par, Default]),
204211
end_per_testcase0(T, Config);
212+
end_per_testcase(T, Config)
213+
when T =:= zero_session_expiry_disconnect_autodeletes_qos0_queue ->
214+
ok = rpc(Config, rabbit_registry, unregister, [queue, <<"qos0">>]),
215+
init_per_testcase0(T, Config);
216+
205217
end_per_testcase(T, Config) ->
206218
end_per_testcase0(T, Config).
207219

@@ -389,6 +401,21 @@ session_expiry_quorum_queue_disconnect_decrease(Config) ->
389401
ok = session_expiry_disconnect_decrease(rabbit_quorum_queue, Config),
390402
ok = rpc(Config, application, unset_env, [?APP, durable_queue_type]).
391403

404+
zero_session_expiry_disconnect_autodeletes_qos0_queue(Config) ->
405+
ClientId = ?FUNCTION_NAME,
406+
C = connect(ClientId, Config, [
407+
{clean_start, false},
408+
{properties, #{'Session-Expiry-Interval' => 0}}]),
409+
{ok, _, _} = emqtt:subscribe(C, <<"topic0">>, qos0),
410+
QsQos0 = rpc(Config, rabbit_amqqueue, list_by_type, [rabbit_mqtt_qos0_queue]),
411+
?assertEqual(1, length(QsQos0)),
412+
413+
ok = emqtt:disconnect(C),
414+
%% After terminating a clean session, we expect any session state to be cleaned up on the server.
415+
timer:sleep(200), %% Give some time to clean up exclusive classic queue.
416+
L = rpc(Config, rabbit_amqqueue, list, []),
417+
?assertEqual(0, length(L)).
418+
392419
session_expiry_disconnect_decrease(QueueType, Config) ->
393420
ClientId = ?FUNCTION_NAME,
394421
C1 = connect(ClientId, Config, [{properties, #{'Session-Expiry-Interval' => 100}}]),

0 commit comments

Comments
 (0)