Skip to content

Commit bde71d2

Browse files
dcorbachomichaelklishin
authored andcommitted
Update metrics gc to support gc marker
1 parent 8313006 commit bde71d2

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/rabbit_core_metrics_gc.erl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ gc_gen_server2() ->
9696
gc_process(Table) ->
9797
ets:foldl(fun({Pid = Key, _}, none) ->
9898
gc_process(Pid, Table, Key);
99+
({Pid = Key, _, _, _, _}, none) ->
100+
gc_process(Pid, Table, Key);
99101
({Pid = Key, _, _, _}, none) ->
100102
gc_process(Pid, Table, Key)
101103
end, none, Table).
@@ -115,6 +117,8 @@ gc_entity(Table, GbSet) ->
115117
gc_entity(Id, Table, Key, GbSet);
116118
({Id = Key, _}, none) ->
117119
gc_entity(Id, Table, Key, GbSet);
120+
({Id = Key, _, _}, none) ->
121+
gc_entity(Id, Table, Key, GbSet);
118122
({Id = Key, _, _, _, _}, none) ->
119123
gc_entity(Id, Table, Key, GbSet)
120124
end, none, Table).
@@ -130,11 +134,11 @@ gc_entity(Id, Table, Key, GbSet) ->
130134
end.
131135

132136
gc_process_and_entity(Table, GbSet) ->
133-
ets:foldl(fun({{Pid, Id} = Key, _, _, _, _, _, _}, none)
137+
ets:foldl(fun({{Pid, Id} = Key, _, _, _, _, _, _, _}, none)
134138
when Table == channel_queue_metrics ->
135139
gc_entity(Id, Table, Key, GbSet),
136140
gc_process(Pid, Table, Key);
137-
({{Pid, Id} = Key, _, _, _}, none)
141+
({{Pid, Id} = Key, _, _, _, _}, none)
138142
when Table == channel_exchange_metrics ->
139143
gc_entity(Id, Table, Key, GbSet),
140144
gc_process(Pid, Table, Key);
@@ -157,7 +161,7 @@ gc_process_and_entity(Id, Pid, Table, Key, GbSet) ->
157161
end.
158162

159163
gc_process_and_entities(Table, QueueGbSet, ExchangeGbSet) ->
160-
ets:foldl(fun({{Pid, {Q, X}} = Key, _}, none) ->
164+
ets:foldl(fun({{Pid, {Q, X}} = Key, _, _}, none) ->
161165
gc_process(Pid, Table, Key),
162166
gc_entity(Q, Table, Key, QueueGbSet),
163167
gc_entity(X, Table, Key, ExchangeGbSet)

test/rabbit_core_metrics_gc_SUITE.erl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ queue_metrics(Config) ->
106106
[queue_metrics, Q]),
107107
[_] = rabbit_ct_broker_helpers:rpc(Config, A, ets, lookup,
108108
[queue_coarse_metrics, Q]),
109-
110109
%% Trigger gc. When the gen_server:call returns, the gc has already finished.
111110
rabbit_ct_broker_helpers:rpc(Config, A, erlang, send, [rabbit_core_metrics_gc, start_gc]),
112111
rabbit_ct_broker_helpers:rpc(Config, A, gen_server, call, [rabbit_core_metrics_gc, test]),

0 commit comments

Comments
 (0)