Delete mqtt qos0 when connection closes

Author: MarcialRosales

deps/rabbitmq_mqtt/src/rabbit_mqtt_processor.erl

@@ -1906,7 +1906,7 @@ log_delayed_will_failure(Topic, ClientId, Reason) ->
                [Topic, ClientId, Reason]).
 
 maybe_delete_mqtt_qos0_queue(
-  State = #state{cfg = #cfg{clean_start = true},
+  State = #state{cfg = #cfg{session_expiry_interval_secs = 0},
                  auth_state = #auth_state{user = #user{username = Username}}}) ->
     case get_queue(?QOS_0, State) of
         {ok, Q} ->

selenium/package.json

@@ -12,7 +12,7 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "chromedriver": "^135.0",
+    "chromedriver": "^137.0",
     "ejs": "^3.1.8",
     "express": "^4.18.2",
     "geckodriver": "^3.0.2",

selenium/test/queuesAndStreams/autodelete-mqtt-qos0.js

@@ -2,8 +2,8 @@ const { By, Key, until, Builder } = require('selenium-webdriver')
 require('chromedriver')
 const assert = require('assert')
 const { buildDriver, goToHome, goToQueue, captureScreensFor, teardown, doUntil, findTableRow } = require('../utils')
-const { createQueue, deleteQueue, getManagementUrl, basicAuthorization } = require('../mgt-api')
-const mqtt = require('mqtt')
+const { createQueue, getManagementUrl, basicAuthorization } = require('../mgt-api')
+const { openConnection, getConnectionOptions } = require('../mqtt')
 
 const LoginPage = require('../pageobjects/LoginPage')
 const OverviewPage = require('../pageobjects/OverviewPage')
@@ -14,20 +14,12 @@ const ConnectionsPage = require('../pageobjects/ConnectionsPage');
 
 describe('Given an MQTT 5.0 connection with a qos 0 subscription with zero sessionExpiryInterval', function () {
   let login
-  let queuesAndStreams
+  let queuesAndStreamsPage
   let queuePage
   let overview
   let captureScreen
   let queueName
-  let mqttOptions
 
-  let mqttProtocol = process.env.MQTT_PROTOCOL || 'mqtt'
-  let usemtls = process.env.MQTT_USE_MTLS || false
-  let rabbit = process.env.RABBITMQ_HOSTNAME || 'localhost'
-  let mqttUrl = process.env.RABBITMQ_MQTT_URL || "mqtt://" + rabbit + ":1883"
-  let username = process.env.RABBITMQ_AMQP_USERNAME || 'management'
-  let password = process.env.RABBITMQ_AMQP_PASSWORD || 'guest'
-  let client_id = process.env.RABBITMQ_AMQP_USERNAME || 'selenium-client'
   let mqttClient 
 
   before(async function () {
@@ -52,30 +44,7 @@ describe('Given an MQTT 5.0 connection with a qos 0 subscription with zero sessi
         "x-queue-type": "quorum"
       })
 
-    mqttOptions = {
-      clientId: client_id,
-      protocolId: 'MQTT',
-      protocol: mqttProtocol,
-      protocolVersion: 5,
-      keepalive: 10000,
-      clean: true,
-      reconnectPeriod: '1000',
-      properties: {
-        sessionExpiryInterval: 0 
-      }
-    }
-    if (mqttProtocol == 'mqtts') {
-      mqttOptions["ca"] = [fs.readFileSync(process.env.RABBITMQ_CERTS + "/ca_rabbitmq_certificate.pem")]      
-    } 
-    if (usemtls) {
-      mqttOptions["cert"] = fs.readFileSync(process.env.RABBITMQ_CERTS + "/client_rabbitmq_certificate.pem")
-      mqttOptions["key"] = fs.readFileSync(process.env.RABBITMQ_CERTS + "/client_rabbitmq_key.pem")
-    } else {
-      mqttOptions["username"] = username
-      mqttOptions["password"] = password
-    }
-
-    mqttClient = mqtt.connect(mqttUrl, mqttOptions)
+    mqttClient = openConnection(getConnectionOptions())
     let subscribed = new Promise((resolve, reject) => {
         mqttClient.on('error', function(err) {
           reject(err)