Fix dialyzer errors

Author: MarcialRosales

deps/rabbitmq_auth_backend_oauth2/src/rabbit_auth_backend_oauth2.erl

@@ -106,7 +106,6 @@ update_state(AuthUser, NewToken) ->
         {_, _} = Tuple ->
             case check_token(NewToken, Tuple) of
                 %% avoid logging the token
-                {error, _} = E  -> E;
                 {refused, {error, {invalid_token, error, _Err, _Stacktrace}}} ->
                     {refused, "Authentication using an OAuth 2/JWT token failed: provided token is invalid"};
                 {refused, Err} ->
@@ -136,7 +135,6 @@ authenticate(_, AuthProps0) ->
             {refused, "Authentication using OAuth 2/JWT token failed: ~tp", [Err0]};
         {ResourceServer, _} = Tuple ->
             case check_token(Token, Tuple) of
-                {error, _} = E  -> E;
                 {refused, {error, {invalid_token, error, _Err, _Stacktrace}}} ->
                     {refused, "Authentication using an OAuth 2/JWT token failed: provided token is invalid", []};
                 {refused, Err} ->

deps/rabbitmq_auth_backend_oauth2/src/resource_server.erl

@@ -58,7 +58,7 @@ resolve_resource_server_from_audience(Audience) ->
 
 -spec get_root_resource_server_id() -> resource_server_id().
 get_root_resource_server_id() ->
-    get_env(resource_server_id).
+    get_env(resource_server_id, <<>>).
 
 -spec get_root_resource_server() -> resource_server().
 get_root_resource_server() ->
@@ -80,7 +80,7 @@ get_root_resource_server() ->
         get_env(extra_scopes_source),
     DefaultScopePrefix =
         case ResourceServerId of
-            undefined -> undefined;
+            <<>> -> undefined;
             _ -> erlang:iolist_to_binary([ResourceServerId, <<".">>])
         end,
     ScopePrefix =
@@ -102,17 +102,18 @@ get_root_resource_server() ->
         oauth_provider_id = OAuthProviderId
     }.
 
--spec get_resource_server(resource_server_id()) -> resource_server().
+-spec get_resource_server(resource_server_id()) -> resource_server() | undefined.
 get_resource_server(ResourceServerId) ->
     RootResourseServer = get_root_resource_server(),
     RootResourseServerId = RootResourseServer#resource_server.id,
     case ResourceServerId of
-        undefined -> undefined;
+        <<>> -> undefined;
         RootResourseServerId -> RootResourseServer;
         _ -> get_resource_server(ResourceServerId, RootResourseServer)
     end.
 
--spec get_resource_server(resource_server_id(), resource_server()) -> resource_server().
+-spec get_resource_server(ResourceServerId :: resource_server_id(),
+    DefaultResourceServerSettings :: resource_server()) -> resource_server().
 get_resource_server(ResourceServerId, RootResourseServer) when
         ResourceServerId == RootResourseServer#resource_server.id ->
     RootResourseServer;
@@ -202,7 +203,7 @@ find_unique_resource_server_without_verify_aud() ->
     Map0 = maps:filter(fun(_K,V) -> not get_boolean_value(verify_aud, V,
         Root#resource_server.verify_aud) end, get_env(resource_servers, #{})),
     Map = case {Root#resource_server.id, Root#resource_server.verify_aud}  of
-        {undefined, _} -> Map0;
+        {<<>>, _} -> Map0;
         {_, true} -> Map0;
         {Id, false} -> maps:put(Id, Root, Map0)
     end,
@@ -214,7 +215,7 @@ find_unique_resource_server_without_verify_aud() ->
 
 append(List, Value) ->
     case Value of
-        undefined -> List;
+        <<>> -> List;
         _ -> List ++ [Value]
     end.
 get_env(Par) ->