Fix tests

update_secret will always return ok even though it is
not. That is because it sends ok to all the channels. And
then it sends an error to the connection.

Author: MarcialRosales

deps/rabbitmq_auth_backend_oauth2/src/rabbit_auth_backend_oauth2.erl

@@ -110,8 +110,6 @@ check_topic_access(#auth_user{impl = DecodedTokenFun},
         end).
 
 update_state(AuthUser, NewToken) ->
-    ?LOG_DEBUG("Calling (update_state)"),
-    
     TokenResult = case oauth2_client:is_jwt_token(NewToken) of 
         true -> {ok, NewToken};
         false -> 
@@ -124,7 +122,6 @@ update_state(AuthUser, NewToken) ->
                     {error, Err1}
             end
     end,
-    ?LOG_DEBUG("Calling (update_state) tokenResult: ~p", [TokenResult]),
     case TokenResult of 
         {ok, Token} ->
             case resolve_resource_server(Token) of

deps/rabbitmq_auth_backend_oauth2/test/system_SUITE.erl

@@ -88,9 +88,9 @@ groups() ->
       {with_introspection_endpoint, [], [
         test_successful_connection_with_valid_opaque_token,
         test_unsuccessful_connection_with_invalid_opaque_token,
-        test_successful_opaque_token_refresh
-        %test_successful_opaque_token_refresh_with_more_restrictive_token,
-        %test_unsuccessful_opaque_token_refresh_with_inactive_token
+        test_successful_opaque_token_refresh,
+        test_successful_opaque_token_refresh_with_more_restrictive_token,
+        test_unsuccessful_opaque_token_refresh_with_inactive_token
       ]}
     ].
 
@@ -573,11 +573,12 @@ test_unsuccessful_opaque_token_refresh_with_inactive_token(Config) ->
     #'queue.declare_ok'{queue = _} =
         amqp_channel:call(Ch, #'queue.declare'{exclusive = true}),
 
-    Result = amqp_connection:update_secret(Conn, <<"inactive">>, <<"token refresh">>),
-    ct:log("Result: ~p", [Result]),
-
-    ?assertException(exit, {{nodedown,not_allowed},_}, Result).
+    amqp_connection:update_secret(Conn, <<"inactive">>, <<"token refresh">>),
+    
+    ?assertExit({{shutdown, {connection_closing, {server_initiated_close, 530, _}}}, _},
+       amqp_connection:open_channel(Conn)),
 
+    catch close_connection(Conn).   
 
 
 mqtt(Config) ->
@@ -1087,12 +1088,17 @@ test_failed_token_refresh_case1(Config) ->
     catch close_connection(Conn).
 
 refreshed_token_cannot_change_username(Config) ->
-    {_, Token} = generate_valid_token_with_sub(Config, <<"username">>),
-    Conn     = open_unmanaged_connection(Config, 0, <<"vhost4">>, <<"username">>, Token),
+    {_, Token} = generate_valid_token_with_sub(Config, <<"username3">>),
+    Conn     = open_unmanaged_connection(Config, 0, <<"vhost1">>, <<"username3">>, Token),
     {_, RefreshedToken} = generate_valid_token_with_sub(Config, <<"username2">>),
 
     %% the error is communicated asynchronously via a connection-level error
-    ?assertException(exit, {{nodedown,not_allowed},_}, amqp_connection:update_secret(Conn, RefreshedToken, <<"token refresh">>)).
+    amqp_connection:update_secret(Conn, RefreshedToken, <<"should fail token refresh">>),
+
+    ?assertExit({{shutdown, {connection_closing, {server_initiated_close, 530, _}}}, _},
+       amqp_connection:open_channel(Conn)),
+
+    catch close_connection(Conn).    
 
 
 test_failed_token_refresh_case2(Config) ->