per_user_connection_channel_tracking_SUITE: Wait for the expected list of connections

[Why]
In CI, we sometimes observe two tracked connections in the return value.
I don't know yet what they are. Could it be a client that reopened its
crashed connection and because stats are updated asynchronously, we get
two tracked connections for a short period of time?

Author: dumbbell

deps/rabbit/test/per_user_connection_channel_tracking_SUITE.erl

@@ -130,7 +130,7 @@ single_node_user_connection_channel_tracking(Config) ->
     [Conn1] = open_connections(Config, [0]),
     [Chan1] = open_channels(Conn1, 1),
     ?awaitMatch(1, count_connections_in(Config, Username), ?A_TOUT),
-    [#tracked_connection{username = Username}] = connections_in(Config, Username),
+    ?awaitMatch([#tracked_connection{username = Username}], connections_in(Config, Username), ?A_TOUT),
     ?awaitMatch(1, count_channels_in(Config, Username), ?A_TOUT),
     [#tracked_channel{username = Username}] = channels_in(Config, Username),
     ?awaitMatch(true, is_process_alive(Conn1), ?A_TOUT),
@@ -147,7 +147,7 @@ single_node_user_connection_channel_tracking(Config) ->
     [Conn2] = open_connections(Config, [{0, Username2}]),
     Chans2  = [_|_] = open_channels(Conn2, 5),
     ?awaitMatch(1, count_connections_in(Config, Username2), ?A_TOUT),
-    [#tracked_connection{username = Username2}] = connections_in(Config, Username2),
+    ?awaitMatch([#tracked_connection{username = Username2}], connections_in(Config, Username2), ?A_TOUT),
     ?awaitMatch(5, count_channels_in(Config, Username2), ?A_TOUT),
     ?awaitMatch(1, tracked_user_connection_count(Config, Username2), ?A_TOUT),
     ?awaitMatch(5, tracked_user_channel_count(Config, Username2), ?A_TOUT),
@@ -157,7 +157,7 @@ single_node_user_connection_channel_tracking(Config) ->
     [Conn3] = open_connections(Config, [0]),
     Chans3 = [_|_] = open_channels(Conn3, 5),
     ?awaitMatch(1, count_connections_in(Config, Username), ?A_TOUT),
-    [#tracked_connection{username = Username}] = connections_in(Config, Username),
+    ?awaitMatch([#tracked_connection{username = Username}], connections_in(Config, Username), ?A_TOUT),
     ?awaitMatch(5, count_channels_in(Config, Username), ?A_TOUT),
     ?awaitMatch(1, tracked_user_connection_count(Config, Username), ?A_TOUT),
     ?awaitMatch(5, tracked_user_channel_count(Config, Username), ?A_TOUT),
@@ -172,7 +172,7 @@ single_node_user_connection_channel_tracking(Config) ->
     [?awaitMatch(true, is_process_alive(Ch), ?A_TOUT) || Ch <- Chans4],
     kill_connections([Conn4]),
     ?awaitMatch(1, count_connections_in(Config, Username), ?A_TOUT),
-    [#tracked_connection{username = Username}] = connections_in(Config, Username),
+    ?awaitMatch([#tracked_connection{username = Username}], connections_in(Config, Username), ?A_TOUT),
     ?awaitMatch(5, count_channels_in(Config, Username), ?A_TOUT),
     ?awaitMatch(1, tracked_user_connection_count(Config, Username), ?A_TOUT),
     ?awaitMatch(5, tracked_user_channel_count(Config, Username), ?A_TOUT),
@@ -182,9 +182,11 @@ single_node_user_connection_channel_tracking(Config) ->
     [Conn5] = open_connections(Config, [0]),
     Chans5  = [_|_] = open_channels(Conn5, 7),
     ?awaitMatch(2, count_connections_in(Config, Username), ?A_TOUT),
-    [Username, Username] =
-        lists:map(fun (#tracked_connection{username = U}) -> U end,
-                  connections_in(Config, Username)),
+    ?awaitMatch(
+       [Username, Username],
+       lists:map(fun (#tracked_connection{username = U}) -> U end,
+                 connections_in(Config, Username)),
+       ?A_TOUT),
     ?awaitMatch(12, count_channels_in(Config, Username), ?A_TOUT),
     ?awaitMatch(12, tracked_user_channel_count(Config, Username), ?A_TOUT),
     ?awaitMatch(2, tracked_user_connection_count(Config, Username), ?A_TOUT),