Skip to content

Commit dd5275b

Browse files
committed
rabbit_nodes: No need to filter members twice in list_*()
[Why] The functions were all calling their corresponding `filter_*()` functions which filter members first. Because the initial functions already took a list of members, we don't need to filter them again. [How] We can call the `do_filter_*()` functions directly.
1 parent cea75b5 commit dd5275b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

deps/rabbit/src/rabbit_nodes.erl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ is_reachable(Node) when is_atom(Node) ->
217217

218218
list_reachable() ->
219219
Members = list_members(),
220-
filter_reachable(Members).
220+
do_filter_reachable(Members).
221221

222222
-spec list_unreachable() -> Nodes when
223223
Nodes :: [node()].
@@ -293,7 +293,6 @@ is_running(Node) when is_atom(Node) ->
293293
is_running(Nodes) when is_list(Nodes) ->
294294
lists:sort(Nodes) =:= lists:sort(filter_running(Nodes)).
295295

296-
297296
-spec list_running() -> Nodes when
298297
Nodes :: [node()].
299298
%% @doc Returns the list of nodes in the cluster where RabbitMQ is running.
@@ -306,7 +305,7 @@ is_running(Nodes) when is_list(Nodes) ->
306305

307306
list_running() ->
308307
Members = list_members(),
309-
filter_running(Members).
308+
do_filter_running(Members).
310309

311310
-spec list_not_running() -> Nodes when
312311
Nodes :: [node()].
@@ -406,7 +405,7 @@ is_serving(Node) when is_atom(Node) ->
406405

407406
list_serving() ->
408407
Members = list_members(),
409-
filter_serving(Members).
408+
do_filter_serving(Members).
410409

411410
-spec list_not_serving() -> Nodes when
412411
Nodes :: [node()].

0 commit comments

Comments
 (0)